Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 1614703003: Revert of Implement webview.captureVisibleRegion() (Closed)

Created:
4 years, 11 months ago by tsergeant
Modified:
4 years, 11 months ago
CC:
asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, miu+watch_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement webview.captureVisibleRegion() (patchset #9 id:160001 of https://codereview.chromium.org/1582053002/ ) Reason for revert: The test WebViewAPITest.TestCaptureVisibleRegion is failing on several windows bots: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/45040 https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/42690 https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/64394 Original issue's description: > Implement webview.captureVisibleRegion() > > This CL implements webview.captureVisibleRegion(), an extension/apps > API to allow WebView users to capture screenshots of the contents > displayed in a WebView. The surfaces contents capture has been plumbed > via RenderWidgetHostViewChildFrame so this implementation should not > require changes when WebView switches to using OOPIF. > > As part of the implementation, there are two notable refactors: > > 1) CaptureWebContentsFunction has been refactored into > WebContentsCaptureClient to remove the extensions::AsyncExtensionFunction > dependence so that this code can be used by both tabs.captureVisibleTab > and webview.captureVisibleRegion, and > > 2) common code from DelegatedFrameHost has ben moved to > content/browser/compositor/surface_utils.* in order to avoid duplication > as both DelegatedFrameHost and RenderWidgetHostViewChildFrame now > use the code. > > BUG=326755 > > Committed: https://crrev.com/5b8cdcc82fc9da7bab15fd3dbf65df843dc73589 > Cr-Commit-Position: refs/heads/master@{#370565} TBR=rockot@chromium.org,creis@chromium.org,kenrb@chromium.org,nick@chromium.org,fsamuel@chromium.org,wjmaclean@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=326755 Committed: https://crrev.com/b30b1aaf04cb1cae5c455461c8c5c418dd7c2aea Cr-Commit-Position: refs/heads/master@{#370641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+397 lines, -642 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_api.h View 2 chunks +4 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M chrome/common/extensions/api/webview_tag.json View 1 chunk +0 lines, -22 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.h View 1 chunk +15 lines, -0 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 3 chunks +152 lines, -4 lines 0 comments Download
M content/browser/compositor/surface_utils.h View 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/compositor/surface_utils.cc View 3 chunks +0 lines, -171 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 2 chunks +4 lines, -16 lines 0 comments Download
A extensions/browser/api/capture_web_contents_function.h View 1 chunk +67 lines, -0 lines 0 comments Download
A extensions/browser/api/capture_web_contents_function.cc View 1 chunk +150 lines, -0 lines 0 comments Download
M extensions/browser/api/guest_view/extension_view/extension_view_internal_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/guest_view/web_view/web_view_internal_api.h View 2 chunks +1 line, -24 lines 0 comments Download
M extensions/browser/api/guest_view/web_view/web_view_internal_api.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D extensions/browser/api/web_contents_capture_client.h View 1 chunk +0 lines, -58 lines 0 comments Download
D extensions/browser/api/web_contents_capture_client.cc View 1 chunk +0 lines, -130 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/common/api/web_view_internal.json View 1 chunk +0 lines, -27 lines 0 comments Download
M extensions/extensions.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/resources/guest_view/web_view/web_view.js View 2 chunks +0 lines, -8 lines 0 comments Download
D extensions/renderer/resources/guest_view/web_view/web_view_experimental.js View 1 chunk +0 lines, -24 lines 0 comments Download
M extensions/test/data/web_view/apitest/main.js View 2 chunks +1 line, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tsergeant
Created Revert of Implement webview.captureVisibleRegion()
4 years, 11 months ago (2016-01-21 06:49:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614703003/1
4 years, 11 months ago (2016-01-21 06:49:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 06:51:08 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 06:51:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b30b1aaf04cb1cae5c455461c8c5c418dd7c2aea
Cr-Commit-Position: refs/heads/master@{#370641}

Powered by Google App Engine
This is Rietveld 408576698