Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 16147007: Revert 151879 "Remove virtual from functions that are never over..." (Closed)

Created:
7 years, 6 months ago by dmazzoni
Modified:
7 years, 6 months ago
Reviewers:
dmazzoni
CC:
blink-reviews
Visibility:
Public.

Description

Revert 151879 "Remove virtual from functions that are never over..." Broke two Chromium tests BUG=247325 > Remove virtual from functions that are never overridden. > > I checked these by writing a quick Python script; none of these functions > are found in any other header files in this directory. > > I was surprised how much this cuts down on code size. I'm going to > aggressively get rid of virtual functions when they're not useful. > The main reason this helps so much is because there are so many subclasses > of AccessibilityObject. > > BUG=247082 > > Review URL: https://chromiumcodereview.appspot.com/16465002 TBR=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M trunk/Source/core/accessibility/AccessibilityNodeObject.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/accessibility/AccessibilityObject.h View 14 chunks +57 lines, -57 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dmazzoni
7 years, 6 months ago (2013-06-06 15:26:49 UTC) #1
dmazzoni
7 years, 6 months ago (2013-06-06 15:26:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r151938.

Powered by Google App Engine
This is Rietveld 408576698