Locate appropriate "winreg" module under both native Win32 and CygWin.

Locate appropriate "winreg" module under both native Win32 and CygWin.

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298362

[bcwhite, 2016-01-21 20:33:00]

bcwhite@chromium.org changed reviewers:
+ brucedawson@chromium.org

[Dirk Pranke, 2016-01-21 20:42:57]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-01-21 20:42:57]

lgtm.

I don't think we should invest a *huge* amount of time trying to get everything
to work under cygwin, but being able to at least fetch the toolchains is
reasonable.

[brucedawson, 2016-01-21 21:03:22]

lgtm

https://codereview.chromium.org/1614663003/diff/1/win_toolchain/get_toolchain...
File win_toolchain/get_toolchain_if_necessary.py (right):

https://codereview.chromium.org/1614663003/diff/1/win_toolchain/get_toolchain...
win_toolchain/get_toolchain_if_necessary.py:44: import winreg
Why are you importing winreg? Why not just "import _winreg as winreg"? Python 3
forward compatibility?

[bcwhite, 2016-01-22 00:19:01]

On 2016/01/21 21:03:22, brucedawson wrote:
> lgtm
> 
>
https://codereview.chromium.org/1614663003/diff/1/win_toolchain/get_toolchain...
> File win_toolchain/get_toolchain_if_necessary.py (right):
> 
>
https://codereview.chromium.org/1614663003/diff/1/win_toolchain/get_toolchain...
> win_toolchain/get_toolchain_if_necessary.py:44: import winreg
> Why are you importing winreg? Why not just "import _winreg as winreg"? Python
3
> forward compatibility?

I took it from the sample code for using cygwinreg.  Seemed reasonable.

[brucedawson, 2016-01-22 00:59:36]

> I took it from the sample code for using cygwinreg.  Seemed reasonable.

It's harmless, but unless we switch to Python 3 it also doesn't add any value.
The Python 2 name for the module is _winreg, the Python 3 name is winreg.

Anyway, your call on whether you want to keep it.

[bcwhite, 2016-01-22 18:12:14]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2016-01-22 18:12:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614663003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614663003/1

[commit-bot: I haz the power, 2016-01-22 18:14:10]

Description was changed from

==========
Locate appropriate "winreg" module under both native Win32 and CygWin.

BUG=
==========

to

==========
Locate appropriate "winreg" module under both native Win32 and CygWin.

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298362
==========

[commit-bot: I haz the power, 2016-01-22 18:14:11]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298362