MacViews: Bubbles and dialogs behave more like sheets wrt main status

ui/views/widget/native_widget_mac_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/widget/native_widget_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
 #import "base/mac/foundation_util.h"
 #import "base/mac/scoped_nsobject.h"
 #import "base/mac/scoped_objc_class_swizzler.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/test_timeouts.h"
 #import "testing/gtest_mac.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/skia/include/core/SkCanvas.h"
 #import "ui/base/cocoa/constrained_window/constrained_window_animation.h"
 #import "ui/base/cocoa/window_size_constants.h"
 #import "ui/events/test/cocoa_test_event_utils.h"
 #include "ui/events/test/event_generator.h"
 #import "ui/gfx/mac/coordinate_conversion.h"
+#include "ui/views/bubble/bubble_delegate.h"
 #import "ui/views/cocoa/bridged_native_widget.h"
 #import "ui/views/cocoa/native_widget_mac_nswindow.h"
 #include "ui/views/controls/button/label_button.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/native_cursor.h"
 #include "ui/views/test/test_widget_observer.h"
 #include "ui/views/test/widget_test.h"
 #include "ui/views/widget/native_widget_private.h"
 #include "ui/views/window/dialog_delegate.h"
 
@@ skipping 896 matching lines @@
   EXPECT_FALSE([regular_widget->GetNativeWindow() canBecomeMainWindow]);
 
   // Create a dialog widget (also TYPE_WINDOW), but with a DialogDelegate.
   Widget* dialog_widget = views::DialogDelegate::CreateDialogWidget(
       new ModalDialogDelegate(ui::MODAL_TYPE_CHILD), nullptr,
       regular_widget->GetNativeView());
   EXPECT_TRUE([dialog_widget->GetNativeWindow() canBecomeKeyWindow]);
   // Dialogs shouldn't take main status away from their parent.
   EXPECT_FALSE([dialog_widget->GetNativeWindow() canBecomeMainWindow]);
 
+  // Create a bubble widget with a parent: also shouldn't get main.
+  BubbleDelegateView* bubble_view = new BubbleDelegateView();
+  bubble_view->set_parent_window(regular_widget->GetNativeView());
+  Widget* bubble_widget = BubbleDelegateView::CreateBubble(bubble_view);
+  EXPECT_TRUE([bubble_widget->GetNativeWindow() canBecomeKeyWindow]);
+  EXPECT_FALSE([bubble_widget->GetNativeWindow() canBecomeMainWindow]);
+
+  // But a bubble without a parent should still be able to become main.
+  Widget* toplevel_bubble_widget =
+      BubbleDelegateView::CreateBubble(new BubbleDelegateView());
+  EXPECT_TRUE([toplevel_bubble_widget->GetNativeWindow() canBecomeKeyWindow]);
+  EXPECT_TRUE([toplevel_bubble_widget->GetNativeWindow() canBecomeMainWindow]);
+
+  toplevel_bubble_widget->CloseNow();
   regular_widget->CloseNow();
 }
 
 NSData* WindowContentsAsTIFF(NSWindow* window) {
   NSView* frame_view = [[window contentView] superview];
   EXPECT_TRUE(frame_view);
 
   // Inset to mask off left and right edges which vary in HighDPI.
   NSRect bounds = NSInsetRect([frame_view bounds], 4, 0);
 
@@ skipping 150 matching lines @@
 @implementation NativeWidgetMacTestWindow
 
 @synthesize invalidateShadowCount = invalidateShadowCount_;
 
 - (void)invalidateShadow {
   ++invalidateShadowCount_;
   [super invalidateShadow];
 }
 
 @end