Issue 16146007: Revert 202580 "Add CompositingReasons to compositor layer types."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16146007: Revert 202580 "Add CompositingReasons to compositor layer types." (Closed)

Created:
7 years, 6 months ago by Julien - ping for review

Modified:
7 years, 6 months ago

Reviewers:
shawnsingh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 202580 "Add CompositingReasons to compositor layer types." It regressed a test on Blink: * compositing/iframes/iframe-content-flipping.html * virtual/softwarecompositing/iframes/iframe-content-flipping.html > Add CompositingReasons to compositor layer types. > > BUG=240946 > > Review URL: https://chromiumcodereview.appspot.com/15051011 TBR=shawnsingh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202663

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -351 lines)			Patch
M	trunk/src/cc/cc.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	trunk/src/cc/layers/compositing_reasons.h	View	1 chunk	+0 lines, -51 lines	0 comments	Download
M	trunk/src/cc/layers/layer.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/cc/layers/layer.cc	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/src/cc/layers/layer_impl.h	View	3 chunks	+0 lines, -10 lines	0 comments	Download
M	trunk/src/cc/layers/layer_impl.cc	View	3 chunks	+0 lines, -124 lines	0 comments	Download
M	trunk/src/cc/layers/layer_unittest.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/webkit/renderer/compositor_bindings/compositor_bindings.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	trunk/src/webkit/renderer/compositor_bindings/web_compositing_reasons.cc	View	1 chunk	+0 lines, -144 lines	0 comments	Download
M	trunk/src/webkit/renderer/compositor_bindings/web_layer_impl.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/src/webkit/renderer/compositor_bindings/web_layer_impl.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

Julien - ping for review

7 years, 6 months ago (2013-05-28 22:07:56 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r202663.