Minor refactor of MaybeMigrateOrCloseSessions.

Minor refactor of MaybeMigrateOrCloseSessions, in preparation for CL(s) implementing migration on QUIC timeouts.

BUG=576998
Committed: https://crrev.com/ae8cfdc3b8826cb5ac22853a05a95c399a42b3fc
Cr-Commit-Position: refs/heads/master@{#370755}

[Jana, 2016-01-21 01:46:39]

Description was changed from

==========
Refactoring MaybeMigrateOrCloseSessions.

BUG=576998
==========

to

==========
Minor refactor of MaybeMigrateOrCloseSessions, in preparation for CL(s)
implementing migration on QUIC timeouts.

BUG=576998
==========

[Jana, 2016-01-21 01:46:39]

jri@chromium.org changed reviewers:
+ rch@chromium.org

[Ryan Hamilton, 2016-01-21 15:16:02]

lgtm, modulo one minor cleanup

https://codereview.chromium.org/1614573002/diff/1/net/quic/quic_stream_factor...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/1614573002/diff/1/net/quic/quic_stream_factor...
net/quic/quic_stream_factory.cc:1200: }
This can now be simpler:

NetworkChangeNotifier::NetworkHandle QuicStreamFactory::FindAlternateNetwork(
     NetworkChangeNotifier::NetworkHandle old_network){
  NetworkChangeNotifier::NetworkList networks;
  NetworkChangeNotifier::GetConnectedNetworks(&networks);
  for (NetworkChangeNotifier::NetworkHandle new_network : networks) {
    if (new_network != old_network)
      return network;
  }
  return NetworkChangeNotifier::kInvalidNetworkHandle;
}

[Jana, 2016-01-21 18:25:50]

Thanks, Ryan. I've incorporated your suggestion. Submitting.

https://codereview.chromium.org/1614573002/diff/1/net/quic/quic_stream_factor...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/1614573002/diff/1/net/quic/quic_stream_factor...
net/quic/quic_stream_factory.cc:1200: }
On 2016/01/21 15:16:02, Ryan Hamilton wrote:
> This can now be simpler:
> 
> NetworkChangeNotifier::NetworkHandle QuicStreamFactory::FindAlternateNetwork(
>      NetworkChangeNotifier::NetworkHandle old_network){
>   NetworkChangeNotifier::NetworkList networks;
>   NetworkChangeNotifier::GetConnectedNetworks(&networks);
>   for (NetworkChangeNotifier::NetworkHandle new_network : networks) {
>     if (new_network != old_network)
>       return network;
>   }
>   return NetworkChangeNotifier::kInvalidNetworkHandle;
> }

Ah, right, of course. Done.

[Jana, 2016-01-21 18:25:58]

The CQ bit was checked by jri@chromium.org

[Jana, 2016-01-21 18:25:58]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1614573002/#ps40001
(title: "Comment nit.")

[commit-bot: I haz the power, 2016-01-21 18:26:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614573002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614573002/40001

[commit-bot: I haz the power, 2016-01-21 19:44:44]

Description was changed from

==========
Minor refactor of MaybeMigrateOrCloseSessions, in preparation for CL(s)
implementing migration on QUIC timeouts.

BUG=576998
==========

to

==========
Minor refactor of MaybeMigrateOrCloseSessions, in preparation for CL(s)
implementing migration on QUIC timeouts.

BUG=576998
==========

[commit-bot: I haz the power, 2016-01-21 19:44:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-21 19:46:29]

Description was changed from

==========
Minor refactor of MaybeMigrateOrCloseSessions, in preparation for CL(s)
implementing migration on QUIC timeouts.

BUG=576998
==========

to

==========
Minor refactor of MaybeMigrateOrCloseSessions, in preparation for CL(s)
implementing migration on QUIC timeouts.

BUG=576998

Committed: https://crrev.com/ae8cfdc3b8826cb5ac22853a05a95c399a42b3fc
Cr-Commit-Position: refs/heads/master@{#370755}
==========

[commit-bot: I haz the power, 2016-01-21 19:46:29]

Patchset 3 (id:??) landed as
https://crrev.com/ae8cfdc3b8826cb5ac22853a05a95c399a42b3fc
Cr-Commit-Position: refs/heads/master@{#370755}