Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1614563002: DevTools: [PrettyPrint] support arrow function (Closed)

Created:
4 years, 11 months ago by lushnikov
Modified:
4 years, 11 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [PrettyPrint] support arrow function BUG=579770 R=pfeldman, dgozman Committed: https://crrev.com/a8684d5bb4e53b6156892dab551a950e284eed53 Cr-Commit-Position: refs/heads/master@{#370773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-6.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-6-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/script_formatter_worker/ESTreeWalker.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lushnikov
ptal
4 years, 11 months ago (2016-01-21 01:18:06 UTC) #1
dgozman
lgtm
4 years, 11 months ago (2016-01-21 19:09:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614563002/1
4 years, 11 months ago (2016-01-21 19:10:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 20:35:50 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 20:37:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8684d5bb4e53b6156892dab551a950e284eed53
Cr-Commit-Position: refs/heads/master@{#370773}

Powered by Google App Engine
This is Rietveld 408576698