Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1614523003: -ansi means -std=c89, so replace -std=gnu99 -ansi with it (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

-ansi means -std=c89, so replace -std=gnu99 -ansi with it Else you could think that the yasm files are compiled as c99. No behavior change. BUG=none Committed: https://crrev.com/2b2e3091da763e168847ec22b6ad1d99704af1bf Cr-Commit-Position: refs/heads/master@{#370907}

Patch Set 1 #

Patch Set 2 : actually #

Patch Set 3 : gn too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/yasm/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/yasm/yasm.gyp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Nico
remember that cl that you reviewed 6 years 2 months ago ( https://codereview.chromium.org/300013 )? It ...
4 years, 11 months ago (2016-01-21 01:27:25 UTC) #2
Mark Mentovai
LGTM
4 years, 11 months ago (2016-01-21 15:16:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614523003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614523003/40001
4 years, 11 months ago (2016-01-22 03:46:57 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-22 04:56:22 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 04:57:53 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2b2e3091da763e168847ec22b6ad1d99704af1bf
Cr-Commit-Position: refs/heads/master@{#370907}

Powered by Google App Engine
This is Rietveld 408576698