Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 1614523002: Remove old-avatar supervised user labels on non-Mac. (Closed)

Created:
4 years, 11 months ago by Peter Kasting
Modified:
4 years, 11 months ago
CC:
chromium-reviews, tfarina, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old-avatar supervised user labels on non-Mac. These are unused; the code to create them is never run because we no longer show avatars on non-incognito windows except in CrOS with multiple sign-in, and in that case AFAICT it's not possible to multiple-sign-in a supervised user. This doesn't remove various resources (strings, images) since they're still used by the Mac code. I'm not able to tell whether than Mac code is also dead. BUG=none TEST=none Committed: https://crrev.com/41bbc33878bb9cb1284c743c4db64203e9cd132d Cr-Commit-Position: refs/heads/master@{#370826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -334 lines) Patch
M chrome/browser/ui/view_ids.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.h View 3 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 4 chunks +0 lines, -32 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc View 6 chunks +2 lines, -55 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
D chrome/browser/ui/views/profiles/supervised_user_avatar_label.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/ui/views/profiles/supervised_user_avatar_label.cc View 1 chunk +0 lines, -136 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Peter Kasting
Adrian, you did a lot of the very early work on the avatar label code, ...
4 years, 11 months ago (2016-01-20 23:49:46 UTC) #2
Adrian Kuegel
Marc Treib is probably the right owner.
4 years, 11 months ago (2016-01-21 08:19:13 UTC) #4
Adrian Kuegel
Btw, thanks for the cleanup. @Marc: I would guess the mac code is dead as ...
4 years, 11 months ago (2016-01-21 08:20:54 UTC) #5
Marc Treib
lgtm, thanks! Yup, the corresponding Mac code will be dead as well. I can make ...
4 years, 11 months ago (2016-01-21 18:29:41 UTC) #6
Peter Kasting
On 2016/01/21 18:29:41, Marc Treib wrote: > lgtm, thanks! > > Yup, the corresponding Mac ...
4 years, 11 months ago (2016-01-21 22:03:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614523002/1
4 years, 11 months ago (2016-01-21 22:05:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 23:28:03 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 23:30:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41bbc33878bb9cb1284c743c4db64203e9cd132d
Cr-Commit-Position: refs/heads/master@{#370826}

Powered by Google App Engine
This is Rietveld 408576698