chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java - Issue 1614513002: Refactor Contextual Search base classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java

Issue 1614513002: Refactor Contextual Search base classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelAnimation.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModeBarControl.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/MockResourcesForLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java

index e4ef8ee3b9298a1a9b5983dfb3ec8ca2306dc21e..a7dedae8305ef574940729192964c3956a36e784 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java

@@ -104,14 +104,14 @@ public class ContextualSearchSceneLayer extends SceneLayer {

float searchPanelWidth = panel.getWidth();

float searchPanelHeight = panel.getHeight();

- float searchBarMarginSide = panel.getSearchBarMarginSide();

- float searchBarHeight = panel.getSearchBarHeight();

+ float searchBarMarginSide = panel.getBarMarginSide();

+ float searchBarHeight = panel.getBarHeight();

- boolean searchBarBorderVisible = panel.isSearchBarBorderVisible();

- float searchBarBorderHeight = panel.getSearchBarBorderHeight();

+ boolean searchBarBorderVisible = panel.isBarBorderVisible();

+ float searchBarBorderHeight = panel.getBarBorderHeight();

- boolean searchBarShadowVisible = panel.getSearchBarShadowVisible();

- float searchBarShadowOpacity = panel.getSearchBarShadowOpacity();

+ boolean searchBarShadowVisible = panel.getBarShadowVisible();

+ float searchBarShadowOpacity = panel.getBarShadowOpacity();

float arrowIconOpacity = panel.getArrowIconOpacity();

float arrowIconRotation = panel.getArrowIconRotation();