chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPeekPromoControl.java - Issue 1614513002: Refactor Contextual Search base classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPeekPromoControl.java

Issue 1614513002: Refactor Contextual Search base classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more renaming Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchTermControl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPeekPromoControl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPeekPromoControl.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPeekPromoControl.java

index 6c9b0fc31dab6ab238458d121fbdfa480ce4415e..97154ff175cb94b77b2e5cccdf84c19b1c743e4f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPeekPromoControl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPeekPromoControl.java

@@ -9,6 +9,8 @@ import android.view.ViewGroup;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel;

+import org.chromium.chrome.browser.compositor.bottombar.OverlayPanelAnimation;

+import org.chromium.chrome.browser.compositor.bottombar.OverlayPanelInflater;

import org.chromium.chrome.browser.compositor.layouts.ChromeAnimation;

import org.chromium.chrome.browser.util.MathUtils;

import org.chromium.ui.resources.dynamics.DynamicResourceLoader;

@@ -16,7 +18,7 @@ import org.chromium.ui.resources.dynamics.DynamicResourceLoader;

/**

* Controls the Search Peek Promo.

-public class ContextualSearchPeekPromoControl extends ContextualSearchInflater

+public class ContextualSearchPeekPromoControl extends OverlayPanelInflater

implements ChromeAnimation.Animatable<ContextualSearchPeekPromoControl.AnimationType> {

/**

@@ -226,7 +228,7 @@ public class ContextualSearchPeekPromoControl extends ContextualSearchInflater

public void animateAppearance() {

// TODO(pedrosimonetti): Find a generic way to tell when a specific animation finishes.

mOverlayPanel.addToAnimation(this, AnimationType.APPEARANCE, 0.f, 1.f,

- ContextualSearchPanelAnimation.BASE_ANIMATION_DURATION_MS, 0);

+ OverlayPanelAnimation.BASE_ANIMATION_DURATION_MS, 0);

}

@Override