Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 1614513002: Refactor Contextual Search base classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources xmlns:tools="http://schemas.android.com/tools"> 6 <resources xmlns:tools="http://schemas.android.com/tools">
7 <!-- Q: Why put style resources under values-v17/ ? 7 <!-- Q: Why put style resources under values-v17/ ?
8 A: Problem: 8 A: Problem:
9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.
10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 <item name="android:visibility">invisible</item> 428 <item name="android:visibility">invisible</item>
429 <!-- 60dp padding minus 7dp for fading edge --> 429 <!-- 60dp padding minus 7dp for fading edge -->
430 <item name="android:paddingStart">53dp</item> 430 <item name="android:paddingStart">53dp</item>
431 <item name="android:paddingEnd">53dp</item> 431 <item name="android:paddingEnd">53dp</item>
432 </style> 432 </style>
433 <style name="ContextualSearchTextView"> 433 <style name="ContextualSearchTextView">
434 <item name="android:layout_height">match_parent</item> 434 <item name="android:layout_height">match_parent</item>
435 <item name="android:ellipsize">end</item> 435 <item name="android:ellipsize">end</item>
436 <item name="android:singleLine">true</item> 436 <item name="android:singleLine">true</item>
437 <item name="android:textColor">#000</item> 437 <item name="android:textColor">#000</item>
438 <item name="android:textSize">@dimen/contextual_search_text_size</item> 438 <item name="android:textSize">@dimen/overlay_panel_text_size</item>
439 </style> 439 </style>
440 <style name="ContextualSearchContextTextView"> 440 <style name="ContextualSearchContextTextView">
441 <item name="android:layout_width">0dp</item> 441 <item name="android:layout_width">0dp</item>
442 <item name="android:layout_height">match_parent</item> 442 <item name="android:layout_height">match_parent</item>
443 <item name="android:ellipsize">none</item> 443 <item name="android:ellipsize">none</item>
444 <item name="android:fadingEdge">horizontal</item> 444 <item name="android:fadingEdge">horizontal</item>
445 <item name="android:fadingEdgeLength">30dp</item> 445 <item name="android:fadingEdgeLength">30dp</item>
446 <item name="android:layout_weight">1</item> 446 <item name="android:layout_weight">1</item>
447 <item name="android:requiresFadingEdge">horizontal</item> 447 <item name="android:requiresFadingEdge">horizontal</item>
448 <item name="android:singleLine">true</item> 448 <item name="android:singleLine">true</item>
449 <item name="android:textColor">#CCC</item> 449 <item name="android:textColor">#CCC</item>
450 <item name="android:textSize">@dimen/contextual_search_text_size</item> 450 <item name="android:textSize">@dimen/overlay_panel_text_size</item>
451 </style> 451 </style>
452 452
453 <!-- Physical Web styles --> 453 <!-- Physical Web styles -->
454 <style name="PhysicalWebNearbyUrlsListStyle" parent="Theme.AppCompat.Light"> 454 <style name="PhysicalWebNearbyUrlsListStyle" parent="Theme.AppCompat.Light">
455 <item name="android:windowBackground">@android:color/white</item> 455 <item name="android:windowBackground">@android:color/white</item>
456 <item name="android:layout_width">match_parent</item> 456 <item name="android:layout_width">match_parent</item>
457 <item name="android:layout_height">match_parent</item> 457 <item name="android:layout_height">match_parent</item>
458 </style> 458 </style>
459 <style name="PhysicalWebOptInStyle" parent="Theme.AppCompat.Light"> 459 <style name="PhysicalWebOptInStyle" parent="Theme.AppCompat.Light">
460 <item name="android:windowBackground">@android:color/white</item> 460 <item name="android:windowBackground">@android:color/white</item>
(...skipping 28 matching lines...) Expand all
489 <style name="UpdateMenuBadge"> 489 <style name="UpdateMenuBadge">
490 <item name="android:layout_height">@dimen/menu_badge_size</item> 490 <item name="android:layout_height">@dimen/menu_badge_size</item>
491 <item name="android:layout_width">@dimen/menu_badge_size</item> 491 <item name="android:layout_width">@dimen/menu_badge_size</item>
492 <item name="android:layout_gravity">end|bottom</item> 492 <item name="android:layout_gravity">end|bottom</item>
493 <item name="android:layout_marginBottom">14dp</item> 493 <item name="android:layout_marginBottom">14dp</item>
494 <item name="android:focusable">false</item> 494 <item name="android:focusable">false</item>
495 <item name="android:importantForAccessibility">no</item> 495 <item name="android:importantForAccessibility">no</item>
496 <item name="android:visibility">invisible</item> 496 <item name="android:visibility">invisible</item>
497 </style> 497 </style>
498 </resources> 498 </resources>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698