Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1893)

Issue 1614443002: DM: dump images for task failures too (but not skipped tasks) (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: dump images for task failures too (but not skipped tasks) This will get us back to uploading things like serialize-8888 mismatches. BUG=skia:4806 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1614443002 Committed: https://skia.googlesource.com/skia/+/ba6ada74e8658571c451f375b3e7736da83ea578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M dm/DM.cpp View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614443002/1
4 years, 11 months ago (2016-01-20 21:02:38 UTC) #3
mtklein_C
4 years, 11 months ago (2016-01-20 21:08:32 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-20 21:15:49 UTC) #7
herb_g
lgtm
4 years, 11 months ago (2016-01-21 17:37:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614443002/1
4 years, 11 months ago (2016-01-21 17:39:01 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 17:39:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ba6ada74e8658571c451f375b3e7736da83ea578

Powered by Google App Engine
This is Rietveld 408576698