Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 16144002: Android WebView: use right variable for android src dir. (Closed)

Created:
7 years, 6 months ago by Torne
Modified:
7 years, 6 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Android WebView: use right variable for android src dir. The Android build system already defines $(PWD) to be the top of the source directory as an absolute path, so there's no need for us to define our own $(GYP_ABS_ANDROID_TOP_DIR) which was being used incorrectly in some other cases. Replace it in GYP_DEFINES. BUG= R=mnaganov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/android/envsetup_functions.sh View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
Hi Ben, I want to get rid of GYP_ABS_ANDROID_TOP_DIR because we're using it wrongly in ...
7 years, 6 months ago (2013-05-28 10:50:53 UTC) #1
Torne
Hi Mikhail, I forgot Ben is on holiday :)
7 years, 6 months ago (2013-05-28 10:53:31 UTC) #2
mnaganov (inactive)
LGTM I guess, the second step will be to update the Android GYP backend?
7 years, 6 months ago (2013-05-28 11:00:31 UTC) #3
Torne
On 2013/05/28 11:00:31, Mikhail Naganov (Chromium) wrote: > LGTM > > I guess, the second ...
7 years, 6 months ago (2013-05-28 11:03:20 UTC) #4
Torne
7 years, 6 months ago (2013-05-28 11:03:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r202530 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698