third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp - Issue 1614343002: Implement CSS4 pseudo-class :dir()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

Issue 1614343002: Implement CSS4 pseudo-class :dir() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated layout tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

index be1b17a26a02cabb1a8b16428e29047761661e2a..89e290f62f5e459010bf75b77eb6a54de373fef4 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

@@ -524,6 +524,14 @@ PassOwnPtr<CSSParserSelector> CSSSelectorParser::consumePseudo(CSSParserTokenRan

selector->setArgument(ident.value());

return selector.release();

}

+ case CSSSelector::PseudoDir:

+ {

+ const CSSParserToken& ident = block.consumeIncludingWhitespace();

+ if (ident.type() != IdentToken || !block.atEnd())

+ return nullptr;

+ selector->setArgument(ident.value());

+ return selector.release();

+ }

case CSSSelector::PseudoNthChild:

case CSSSelector::PseudoNthLastChild:

case CSSSelector::PseudoNthOfType: