Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1614313003: Revert of [runtime] Do not use the enum-cache for non-prototype objects. (Closed)

Created:
4 years, 11 months ago by Camillo Bruni
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #1 id:1 of https://codereview.chromium.org/1612413003/ ) Reason for revert: let me quickly revert the revert, wut? Goal: my CL should not be in the tree! Original issue's description: > Reland of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #1 id:1 of https://codereview.chromium.org/1619803003/ ) > > Reason for revert: > the deopt issues have been taken care of by benedikt > > Original issue's description: > > Revert of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #10 id:180001 of https://codereview.chromium.org/1608523002/ ) > > > > Reason for revert: > > tanks for-in significantly > > > > Original issue's description: > > > [runtime] Do not use the enum-cache for keys retrieval. > > > > > > Currently we fail to properly handle shadowed properties. If the > > > receiver defines a non-enumerable property that reappears on the > > > prototype as enumerable it incorrectly shows up in [[Enumerate]]. > > > By extending the KeyAccumulator to track non-enumerable properties > > > we can now properly filter them out when seeing them further up in > > > the prototype-chain. > > > > > > BUG=v8:705 > > > LOG=y > > > > > > Committed: https://crrev.com/ed24dfe80d1da0827b8571839ee52c03ad09c9c7 > > > Cr-Commit-Position: refs/heads/master@{#33405} > > > > TBR=jkummerow@chromium.org,bmeurer@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=v8:705 > > LOG=n > > > > Committed: https://crrev.com/6e0573c6fff1c3041bab106d1197ab1b64aa9a6a > > Cr-Commit-Position: refs/heads/master@{#33443} > > TBR=jkummerow@chromium.org,bmeurer@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:705 > > Committed: https://crrev.com/5569e270eda517b5ea74e3a7676b3230cbe2f7a9 > Cr-Commit-Position: refs/heads/master@{#33458} TBR=jkummerow@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:705 Committed: https://crrev.com/1c523a444b0dea8f7891c6bf9bc1790bf598023f Cr-Commit-Position: refs/heads/master@{#33459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -213 lines) Patch
M src/elements.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/key-accumulator.h View 4 chunks +0 lines, -13 lines 0 comments Download
M src/key-accumulator.cc View 5 chunks +3 lines, -34 lines 0 comments Download
M src/messages.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.h View 3 chunks +6 lines, -9 lines 0 comments Download
M src/objects.cc View 7 chunks +74 lines, -92 lines 0 comments Download
D test/mjsunit/regress/regress-705-shadowed_properties.js View 1 chunk +0 lines, -57 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Camillo Bruni
Created Revert of [runtime] Do not use the enum-cache for non-prototype objects.
4 years, 11 months ago (2016-01-22 09:10:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614313003/1
4 years, 11 months ago (2016-01-22 09:11:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 09:11:16 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 09:12:17 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c523a444b0dea8f7891c6bf9bc1790bf598023f
Cr-Commit-Position: refs/heads/master@{#33459}

Powered by Google App Engine
This is Rietveld 408576698