Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 16143005: monitor console command implemented. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Moved command implementation to C++. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorDebuggerAgent.cpp
diff --git a/Source/core/inspector/InspectorDebuggerAgent.cpp b/Source/core/inspector/InspectorDebuggerAgent.cpp
index b4e9a0259f1dc7ff5b89f29bd2d802e4c32ce0a7..6a847c96b1986df74dfec311ae082e1aca81d002 100644
--- a/Source/core/inspector/InspectorDebuggerAgent.cpp
+++ b/Source/core/inspector/InspectorDebuggerAgent.cpp
@@ -63,10 +63,22 @@ static const char pauseOnExceptionsState[] = "pauseOnExceptionsState";
const char* InspectorDebuggerAgent::backtraceObjectGroup = "backtrace";
+static String breakpointIdSuffix(InspectorDebuggerAgent::BreakpointSource source)
+{
+ switch (source) {
+ case InspectorDebuggerAgent::UserBreakpointSource:
+ break;
+ case InspectorDebuggerAgent::DebugCommandBreakpointSource:
+ return ":debug";
+ case InspectorDebuggerAgent::MonitorCommandBreakpointSource:
+ return ":monitor";
+ }
+ return String();
+}
+
static String generateBreakpointId(const String& scriptId, int lineNumber, int columnNumber, InspectorDebuggerAgent::BreakpointSource source)
{
- return scriptId + ':' + String::number(lineNumber) + ':' + String::number(columnNumber) +
- (source == InspectorDebuggerAgent::UserBreakpointSource ? String() : String(":debug"));
+ return scriptId + ':' + String::number(lineNumber) + ':' + String::number(columnNumber) + breakpointIdSuffix(source);
}
InspectorDebuggerAgent::InspectorDebuggerAgent(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* inspectorState, InjectedScriptManager* injectedScriptManager)
@@ -828,10 +840,10 @@ void ScriptDebugListener::Script::reportMemoryUsage(MemoryObjectInfo* memoryObje
info.addMember(sourceMappingURL, "sourceMappingURL");
}
-void InspectorDebuggerAgent::setBreakpoint(const String& scriptId, int lineNumber, int columnNumber, BreakpointSource source)
+void InspectorDebuggerAgent::setBreakpoint(const String& scriptId, int lineNumber, int columnNumber, BreakpointSource source, const String& condition)
{
String breakpointId = generateBreakpointId(scriptId, lineNumber, columnNumber, source);
- ScriptBreakpoint breakpoint(lineNumber, columnNumber, String());
+ ScriptBreakpoint breakpoint(lineNumber, columnNumber, condition);
resolveBreakpoint(breakpointId, scriptId, breakpoint, source);
}

Powered by Google App Engine
This is Rietveld 408576698