monitor console command implemented.

Source/core/inspector/InjectedScriptHost.cpp

 /*
  * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 22 matching lines @@
 
 #include "core/inspector/InspectorAgent.h"
 #include "core/inspector/InspectorConsoleAgent.h"
 #include "core/inspector/InspectorDOMAgent.h"
 #include "core/inspector/InspectorDOMStorageAgent.h"
 #include "core/inspector/InspectorDatabaseAgent.h"
 #include "core/inspector/InspectorDebuggerAgent.h"
 #include "core/inspector/InspectorValues.h"
 #include "core/platform/Pasteboard.h"
 
-#include <wtf/RefPtr.h>
-#include <wtf/StdLibExtras.h>
+#include "wtf/RefPtr.h"
+#include "wtf/StdLibExtras.h"
+#include "wtf/text/StringBuilder.h"
 
 using namespace std;
 
 namespace WebCore {
 
 PassRefPtr<InjectedScriptHost> InjectedScriptHost::create()
 {
     return adoptRef(new InjectedScriptHost());
 }
 
@@ skipping 81 matching lines @@
     return String();
 }
 
 String InjectedScriptHost::storageIdImpl(Storage* storage)
 {
     if (m_domStorageAgent)
         return m_domStorageAgent->storageId(storage);
     return String();
 }
 
-void InjectedScriptHost::setBreakpoint(const String& scriptId, int lineNumber, int columnNumber)
+void InjectedScriptHost::debugFunction(const String& scriptId, int lineNumber, int columnNumber)
 {
     m_debuggerAgent->setBreakpoint(scriptId, lineNumber, columnNumber, InspectorDebuggerAgent::DebugCommandBreakpointSource);
 }
 
-void InjectedScriptHost::removeBreakpoint(const String& scriptId, int lineNumber, int columnNumber)
+void InjectedScriptHost::undebugFunction(const String& scriptId, int lineNumber, int columnNumber)
 {
     m_debuggerAgent->removeBreakpoint(scriptId, lineNumber, columnNumber, InspectorDebuggerAgent::DebugCommandBreakpointSource);
 }
 
+void InjectedScriptHost::monitorFunction(const String& scriptId, int lineNumber, int columnNumber, const String& functionName)
+{
+    StringBuilder builder;
+    builder.appendLiteral("console.log(\"function ");
+    if (functionName.isEmpty())
+        builder.appendLiteral("(anonymous function)");
+    else
+        builder.append(functionName);
+    builder.appendLiteral(" called\" + (arguments.length > 0 ? \" with arguments: \" + Array.prototype.join.call(arguments, \", \") : \"\")) && false");

[yurys, 2013/06/17 12:06:14]

This still calls Array.prototype.join that may be overridden by the inspected
code, not sure how bad it is as the code that overrides the method should
already have access to the inspected context. But evaluating it in debugger
context may result in granting extended privileges, can we avoid such call?

[Peter.Rybin, 2013/06/17 14:38:14]

It looks that breakpoint conditions are processed in V8 by
frame.evaluate(condition). This is probably secure enough.

[SeRya, 2013/06/17 15:08:57]

It evaluates in v8/src/debug-debugger.js:
var mirror = exec_state.frame(0).evaluate(this.condition());

then v8/src/mirror-debugger.js:
%DebugEvaluate(this.break_id_,
    this.details_.frameId(),
    this.details_.inlinedFrameIndex(),
    source,
    Boolean(disable_break),
    opt_context_object);

Then executes Runtime_DebugEvaluate in v8/src/runtime.cc.

So I see no way how to debugger context may get to this point.

+    m_debuggerAgent->setBreakpoint(scriptId, lineNumber, columnNumber, InspectorDebuggerAgent::MonitorCommandBreakpointSource, builder.toString());
+}
+
+void InjectedScriptHost::unmonitorFunction(const String& scriptId, int lineNumber, int columnNumber)
+{
+    m_debuggerAgent->removeBreakpoint(scriptId, lineNumber, columnNumber, InspectorDebuggerAgent::MonitorCommandBreakpointSource);
+}
+
 } // namespace WebCore