Shutdown the status tray before the system tray delegate.

ash/root_window_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/root_window_controller.h"
 
 #include <queue>
 #include <vector>
 
 #include "ash/ash_constants.h"
@@ skipping 646 matching lines @@
   }
   aura::Window* keyboard_container =
       keyboard_controller->GetContainerWindow();
   if (keyboard_container->GetRootWindow() == GetRootWindow()) {
     aura::Window* parent =
         GetContainer(kShellWindowId_ImeWindowParentContainer);
     DCHECK(parent);
     parent->RemoveChild(keyboard_container);
     // Virtual keyboard may be deactivated while still showing, notify all
     // observers that keyboard bounds changed to 0 before remove them.
+
+    // Shelf has already been shut down. Don't send a keyboard bounds changing
+    // notification to it.

[stevenjb, 2016/01/25 23:28:17]

This is problematic. Since (presumably) shelf()->shelf_layout_manager() is still
valid here, it needs to know to ignore this notification when it is shut down.
Artificially inverting this ordering is very confusing.

[jdufault, 2016/01/26 00:55:05]

Reverted this change, the keyboard is now deinited before the shelf.

+    keyboard_controller->RemoveObserver(shelf()->shelf_layout_manager());
+
     keyboard_controller->NotifyKeyboardBoundsChanging(gfx::Rect());
-    keyboard_controller->RemoveObserver(shelf()->shelf_layout_manager());
+
     keyboard_controller->RemoveObserver(panel_layout_manager_);
     keyboard_controller->RemoveObserver(docked_layout_manager_);
     keyboard_controller->RemoveObserver(
         workspace_controller_->layout_manager());
     keyboard_controller->RemoveObserver(
         always_on_top_controller_->GetLayoutManager());
     Shell::GetInstance()->delegate()->VirtualKeyboardActivated(false);
   }
 }
 
@@ skipping 378 matching lines @@
   else
     DisableTouchHudProjection();
 }
 
 RootWindowController* GetRootWindowController(
     const aura::Window* root_window) {
   return root_window ? GetRootWindowSettings(root_window)->controller : NULL;
 }
 
 }  // namespace ash