Add "Don't translate" preference to chrome://settings/languages

Add "Don't translate" preference to chrome://settings/languages

This preference allows us to configure whether or not a language should be translated. Currently, this configuration is available only at chrome://translate-internals.

This CL is provisional.

The known problems are below:
  1. New resource files are needed for a new string.
  2. For now, this preference doesn't have any effect because the languages listed in the left column are not translated. I'll fix this logic along with the design doc.

UX Proposal: https://docs.google.com/a/google.com/presentation/d/1se75vXwUSttlR6AMrJO2vJIWzT8Rp8eUAh_Xav3gDl0
Design Doc: https://docs.google.com/a/google.com/document/d/1mxM00l1h2e59HKPVZR_1DY07jeCg4RwHWu7JDvmWx3w

BUG=243235
TEST=Manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203380

[hajimehoshi, 2013-05-28 09:46:20]

Can you take a look at this CL?  Thank you in advance.

[Evan Stade, 2013-05-28 17:08:10]

looks pretty good. In the CL description, s/configurate/configure

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
File chrome/browser/resources/options/language_options.html (right):

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/language_options.html:75:
i18n-content="dont_translate"></span>
the style is really inconsistent in this file (and that's unfortunate) but you
should make two changes here:

1) indent should be 4 spaces (not flush with other attribute)
2) i18n-content value should beCamelCased not c_hacker_cased

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
File chrome/browser/resources/options/language_options.js (right):

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/language_options.js:119:
translateLanguageBlacklistPref_: 'translate_language_blacklist',
as a const this should go up by DOWNLOAD_STATUS

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/language_options.js:122: * The list of the
languages which is not translated.
nit: s/is/are

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/language_options.js:182: var cb =
$('language-options-dont-translate').querySelector('input');
don't abbreviate variable names.

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/language_options.js:766: blacklist =
blacklist.filter(function(l) {
don't abbreviate variable names

[hajimehoshi, 2013-05-29 03:52:22]

Thank you!

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
File chrome/browser/resources/options/language_options.html (right):

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/language_options.html:75:
i18n-content="dont_translate"></span>
1) Done
2) Hmm, I'll do for 'dont_translate' in this CL, and do for the other names in
another CL.

On 2013/05/28 17:08:11, Evan Stade wrote:
> the style is really inconsistent in this file (and that's unfortunate) but you
> should make two changes here:
> 
> 1) indent should be 4 spaces (not flush with other attribute)
> 2) i18n-content value should beCamelCased not c_hacker_cased

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
File chrome/browser/resources/options/language_options.js (right):

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/language_options.js:119:
translateLanguageBlacklistPref_: 'translate_language_blacklist',
On 2013/05/28 17:08:11, Evan Stade wrote:
> as a const this should go up by DOWNLOAD_STATUS

Done.

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/language_options.js:122: * The list of the
languages which is not translated.
On 2013/05/28 17:08:11, Evan Stade wrote:
> nit: s/is/are

Done.

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/language_options.js:182: var cb =
$('language-options-dont-translate').querySelector('input');
On 2013/05/28 17:08:11, Evan Stade wrote:
> don't abbreviate variable names.

Done.

https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/language_options.js:766: blacklist =
blacklist.filter(function(l) {
On 2013/05/28 17:08:11, Evan Stade wrote:
> don't abbreviate variable names

Done.

[hajimehoshi, 2013-05-29 04:40:45]

Created another CL to fix i18n-contents:
https://codereview.chromium.org/16025007/

On 2013/05/29 03:52:22, hajimehoshi wrote:
> Thank you!
> 
>
https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
> File chrome/browser/resources/options/language_options.html (right):
> 
>
https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
> chrome/browser/resources/options/language_options.html:75:
> i18n-content="dont_translate"></span>
> 1) Done
> 2) Hmm, I'll do for 'dont_translate' in this CL, and do for the other names in
> another CL.
> 
> On 2013/05/28 17:08:11, Evan Stade wrote:
> > the style is really inconsistent in this file (and that's unfortunate) but
you
> > should make two changes here:
> > 
> > 1) indent should be 4 spaces (not flush with other attribute)
> > 2) i18n-content value should beCamelCased not c_hacker_cased
> 
>
https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
> File chrome/browser/resources/options/language_options.js (right):
> 
>
https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
> chrome/browser/resources/options/language_options.js:119:
> translateLanguageBlacklistPref_: 'translate_language_blacklist',
> On 2013/05/28 17:08:11, Evan Stade wrote:
> > as a const this should go up by DOWNLOAD_STATUS
> 
> Done.
> 
>
https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
> chrome/browser/resources/options/language_options.js:122: * The list of the
> languages which is not translated.
> On 2013/05/28 17:08:11, Evan Stade wrote:
> > nit: s/is/are
> 
> Done.
> 
>
https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
> chrome/browser/resources/options/language_options.js:182: var cb =
> $('language-options-dont-translate').querySelector('input');
> On 2013/05/28 17:08:11, Evan Stade wrote:
> > don't abbreviate variable names.
> 
> Done.
> 
>
https://codereview.chromium.org/16141002/diff/1/chrome/browser/resources/opti...
> chrome/browser/resources/options/language_options.js:766: blacklist =
> blacklist.filter(function(l) {
> On 2013/05/28 17:08:11, Evan Stade wrote:
> > don't abbreviate variable names
> 
> Done.

[Evan Stade, 2013-05-31 00:05:54]

lgtm

https://codereview.chromium.org/16141002/diff/14001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/language_options_handler_common.cc (right):

https://codereview.chromium.org/16141002/diff/14001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/language_options_handler_common.cc:81:
IDS_OPTIONS_LANGUAGES_DONT_TRANSLATE_IN_THIS_LANGUAGE }
nit: add comma at end

(if the previous author had done this, you wouldn't have had to edit L79)

[hajimehoshi, 2013-05-31 01:27:36]

Thanks!

https://codereview.chromium.org/16141002/diff/14001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/language_options_handler_common.cc (right):

https://codereview.chromium.org/16141002/diff/14001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/language_options_handler_common.cc:81:
IDS_OPTIONS_LANGUAGES_DONT_TRANSLATE_IN_THIS_LANGUAGE }
On 2013/05/31 00:05:54, Evan Stade wrote:
> nit: add comma at end
> 
> (if the previous author had done this, you wouldn't have had to edit L79)

Done.

[commit-bot: I haz the power, 2013-05-31 01:27:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/16141002/23001

[commit-bot: I haz the power, 2013-05-31 03:44:07]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-05-31 04:18:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/16141002/46001

[commit-bot: I haz the power, 2013-05-31 06:42:13]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-05-31 07:08:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/16141002/53001

[commit-bot: I haz the power, 2013-05-31 09:32:32]

Change committed as 203380