chromeos/dbus/fake_debug_daemon_client.h - Issue 1614063005: Adds a callback to TracingAgent::StartAgentTracing()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/fake_debug_daemon_client.h

Issue 1614063005: Adds a callback to TracingAgent::StartAgentTracing() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/dbus/debug_daemon_client.cc ('K') | « chromeos/dbus/debug_daemon_client.cc ('k') | chromeos/dbus/fake_debug_daemon_client.cc » ('j') | chromeos/dbus/fake_debug_daemon_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/dbus/fake_debug_daemon_client.h

diff --git a/chromeos/dbus/fake_debug_daemon_client.h b/chromeos/dbus/fake_debug_daemon_client.h

index a75edbf33c43118c7d7762993cd2dedadabe3794..b7f7799ba650c778436da121bbd81228fcb8ec67 100644

--- a/chromeos/dbus/fake_debug_daemon_client.h

+++ b/chromeos/dbus/fake_debug_daemon_client.h

@@ -31,8 +31,8 @@ class CHROMEOS_EXPORT FakeDebugDaemonClient : public DebugDaemonClient {

const SetDebugModeCallback& callback) override;

std::string GetTracingAgentName() override;

std::string GetTraceEventLabel() override;

- bool StartAgentTracing(

- const base::trace_event::TraceConfig& trace_config) override;

+ void StartAgentTracing(const base::trace_event::TraceConfig& trace_config,

+ const StartAgentTracingCallback& callback) override;

void StopAgentTracing(const StopAgentTracingCallback& callback) override;

void SetStopAgentTracingTaskRunner(

scoped_refptr<base::TaskRunner> task_runner) override;

« chromeos/dbus/debug_daemon_client.cc ('K') | « chromeos/dbus/debug_daemon_client.cc ('k') | chromeos/dbus/fake_debug_daemon_client.cc » ('j') | chromeos/dbus/fake_debug_daemon_client.cc » ('J')