Adds a callback to TracingAgent::StartAgentTracing()

content/browser/tracing/power_tracing_agent.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/lazy_instance.h"
 #include "base/memory/singleton.h"
+#include "base/thread_task_runner_handle.h"
 #include "base/trace_event/trace_event_impl.h"
 #include "content/browser/tracing/battor_power_trace_provider.h"
 #include "content/browser/tracing/power_tracing_agent.h"
 #include "content/public/browser/browser_thread.h"
 
 namespace content {
 
 namespace {
 
 const char kPowerTracingAgentName[] = "battor";
@@ skipping 13 matching lines @@
 PowerTracingAgent::~PowerTracingAgent() {}
 
 std::string PowerTracingAgent::GetTracingAgentName() {
   return kPowerTracingAgentName;
 }
 
 std::string PowerTracingAgent::GetTraceEventLabel() {
   return kPowerTraceLabel;
 }
 
-bool PowerTracingAgent::StartAgentTracing(
-    const base::trace_event::TraceConfig& trace_config) {
+void PowerTracingAgent::StartAgentTracing(
+    const base::trace_event::TraceConfig& trace_config,
+    const StartAgentTracingCallback& callback) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   // TODO(charliea): When system tracing is enabled in about://tracing, it will
   // trigger power tracing. We need a way of checking if BattOr is connected.
   // Currently, IsConnected() always returns false, so that we do not include
   // BattOr trace until it is hooked up.
-  if (!battor_trace_provider_->IsConnected())
-    return false;
-
+  if (!battor_trace_provider_->IsConnected()) {

[Zhen Wang, 2016/01/25 20:35:32]

This is still a sync call here. Will this be updated to async call in later CL?

[charliea (OOO until 10-5), 2016/01/25 21:15:24]

All interaction with the serial classes needs to be done on the IO thread.
However, the IsConnected() call, once on the IO thread, is a synchronous call. I
think that we're going to have 3 main StartTracing functions in this class all
together: StartTracing (on UI thread), StartTracingOnIOThread, and
IsConnected(). StartTracing will defer to StartTracingOnIOThread, which will in
turn call IsConnected.

That was really complicated to explain, but if it doesn't make sense, I think it
should be a lot more clear w/ the next CL.

+    base::ThreadTaskRunnerHandle::Get()->PostTask(
+        FROM_HERE, base::Bind(callback, GetTracingAgentName(), false));
+    return;
+  }
   thread_.Start();
 
   thread_.task_runner()->PostTask(
       FROM_HERE,
       base::Bind(&PowerTracingAgent::TraceOnThread, base::Unretained(this)));
-  return true;
+  base::ThreadTaskRunnerHandle::Get()->PostTask(
+      FROM_HERE, base::Bind(callback, GetTracingAgentName(), true));
 }
 
 void PowerTracingAgent::StopAgentTracing(
     const StopAgentTracingCallback& callback) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   DCHECK(thread_.IsRunning());
 
   thread_.task_runner()->PostTask(
       FROM_HERE,
       base::Bind(&PowerTracingAgent::FlushOnThread, base::Unretained(this),
@@ skipping 63 matching lines @@
   base::TimeTicks issue_ts = base::TimeTicks::Now();
   battor_trace_provider_->RecordClockSyncMarker(sync_id);
   base::TimeTicks issue_end_ts = base::TimeTicks::Now();
 
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(callback, sync_id, issue_ts, issue_end_ts));
 }
 
 }  // namespace content