Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1614053002: [Android WebView] Actualize @Overrides for methods added in Lollipop (Closed)

Created:
4 years, 11 months ago by mnaganov (inactive)
Modified:
4 years, 11 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Actualize @Overrides for methods added in Lollipop Just two of them: WebViewFactoryProvider.Statics.clearClientCertPreferences WebViewFactoryProvider.Statics.enableSlowWholeDocumentDraw Committed: https://crrev.com/4503ca766ad3750cbc0dbb2a012f7caf0d376d74 Cr-Commit-Position: refs/heads/master@{#370728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mnaganov (inactive)
4 years, 11 months ago (2016-01-21 17:41:09 UTC) #2
boliu
lgtm what's the status of merging to downstream glue these days..?
4 years, 11 months ago (2016-01-21 17:47:44 UTC) #3
mnaganov (inactive)
On 2016/01/21 17:47:44, boliu wrote: > lgtm > > what's the status of merging to ...
4 years, 11 months ago (2016-01-21 17:51:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614053002/1
4 years, 11 months ago (2016-01-21 17:52:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 18:11:57 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4503ca766ad3750cbc0dbb2a012f7caf0d376d74 Cr-Commit-Position: refs/heads/master@{#370728}
4 years, 11 months ago (2016-01-21 18:13:08 UTC) #9
mnaganov (inactive)
4 years, 11 months ago (2016-01-21 21:20:31 UTC) #10
Message was sent while issue was closed.
boliu@: Yeah, you have to run the merge script and commit the mirror changes
downstream. Done that for this change.

Powered by Google App Engine
This is Rietveld 408576698