Pepper: Clean up trusted plugin arguments.

Pepper: Clean up trusted plugin arguments.

Argument copying and lookups are a bit more complicated than they have to be.
This cleans up the code a little bit to make the trusted plugin more compact.

BUG=
R=dmichael@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251052

[dmichael (off chromium), 2014-02-12 22:06:46]

lgtm

https://codereview.chromium.org/161403002/diff/1/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/plugin.cc (right):

https://codereview.chromium.org/161403002/diff/1/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/plugin.cc:124: std::string
value(argv[i]);
nit: arguably, you could not have these temp variables at all. Or use const
std::string&. But it's not important.

https://codereview.chromium.org/161403002/diff/1/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/plugin.cc:492: return NULL;
I think it would be clearer to return std::string()

[teravest, 2014-02-12 22:45:25]

On Wed, Feb 12, 2014 at 3:06 PM,  <dmichael@chromium.org> wrote:
> lgtm
>
>
>
>
>
https://codereview.chromium.org/161403002/diff/1/ppapi/native_client/src/trus...
> File ppapi/native_client/src/trusted/plugin/plugin.cc (right):
>
>
https://codereview.chromium.org/161403002/diff/1/ppapi/native_client/src/trus...
> ppapi/native_client/src/trusted/plugin/plugin.cc:124: std::string
> value(argv[i]);
> nit: arguably, you could not have these temp variables at all. Or use
> const std::string&. But it's not important.
>
>
https://codereview.chromium.org/161403002/diff/1/ppapi/native_client/src/trus...
> ppapi/native_client/src/trusted/plugin/plugin.cc:492: return NULL;
> I think it would be clearer to return std::string()

Done.

>
> https://codereview.chromium.org/161403002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[teravest, 2014-02-12 22:45:33]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-02-12 22:46:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/161403002/100001

[commit-bot: I haz the power, 2014-02-13 01:55:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 01:55:04]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[teravest, 2014-02-13 16:27:51]

Committed patchset #2 manually as r251052 (presubmit successful).