Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1614023002: [Cast, Android] Reimplement ReceiverAction.CAST message for the new cast_sender.js (Closed)

Created:
4 years, 11 months ago by whywhat
Modified:
4 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org, Zhiqiang Zhang (Slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast, Android] Reimplement ReceiverAction.CAST message for the new cast_sender.js BUG=580113 TEST=e2e tests with replacing the current script with the new one. For Chrome 50, the new version of cast_sender.js will be served that doesn't use PresentationRequest.join("_receiver-action") to get the receiver action event. Instead, the PresentationConnection is returned immediately after the user picked a device for PresentationRequest.start() and the receiver action message is sent back to the page via the corresponding MediaRoute. This in particular means the route will exist without the CastSession and some messages need to be handled by CastMediaRouteProvider, as well as queued until "client_connected" is sent to the route. Committed: https://crrev.com/9163b64f5ca5314ac5c6713aefb836cbbdf52cc1 Cr-Commit-Position: refs/heads/master@{#371780}

Patch Set 1 #

Patch Set 2 : Improved logging of messages to the client #

Patch Set 3 : Removed unused variable #

Total comments: 1

Messages

Total messages: 18 (7 generated)
whywhat
PTaL
4 years, 11 months ago (2016-01-21 16:40:00 UTC) #2
whywhat
Improved logging of messages to the client
4 years, 11 months ago (2016-01-21 16:57:07 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614023002/20001
4 years, 11 months ago (2016-01-25 11:40:46 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/12343)
4 years, 11 months ago (2016-01-25 12:24:07 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614023002/40001
4 years, 11 months ago (2016-01-26 11:25:41 UTC) #9
whywhat
PTaL
4 years, 11 months ago (2016-01-26 11:25:43 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 12:07:40 UTC) #12
mlamouri (slow - plz ping)
lgtm https://codereview.chromium.org/1614023002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java File chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java (right): https://codereview.chromium.org/1614023002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java#newcode378 chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:378: for (String message : clientRecord.pendingMessages) { nit: if ...
4 years, 11 months ago (2016-01-27 12:45:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614023002/40001
4 years, 11 months ago (2016-01-27 12:46:08 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-27 13:37:06 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 13:38:37 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9163b64f5ca5314ac5c6713aefb836cbbdf52cc1
Cr-Commit-Position: refs/heads/master@{#371780}

Powered by Google App Engine
This is Rietveld 408576698