Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 16140015: [NaCl SDK] Include Ragel ncval in SDK for all validation. (Closed)

Created:
7 years, 6 months ago by binji
Modified:
7 years, 6 months ago
Reviewers:
noelallen1, Sam Clegg
CC:
chromium-reviews, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Include Ragel ncval in SDK for all validation. BUG=226406 R=noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203767

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 3 chunks +3 lines, -9 lines 2 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 chunk +2 lines, -6 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
binji
7 years, 6 months ago (2013-06-03 18:20:44 UTC) #1
noelallen1
lgtm https://codereview.chromium.org/16140015/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/16140015/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode514 native_client_sdk/src/build_tools/build_sdk.py:514: GypNinjaBuild('ia32', gyp_py, all_gyp, 'ncval_new', out_dir) What are we ...
7 years, 6 months ago (2013-06-03 18:28:13 UTC) #2
binji
https://codereview.chromium.org/16140015/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/16140015/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode514 native_client_sdk/src/build_tools/build_sdk.py:514: GypNinjaBuild('ia32', gyp_py, all_gyp, 'ncval_new', out_dir) On 2013/06/03 18:28:13, noelallen1 ...
7 years, 6 months ago (2013-06-03 18:32:33 UTC) #3
Sam Clegg
https://codereview.chromium.org/16140015/diff/1/native_client_sdk/src/build_tools/sdk_files.list File native_client_sdk/src/build_tools/sdk_files.list (right): https://codereview.chromium.org/16140015/diff/1/native_client_sdk/src/build_tools/sdk_files.list#newcode982 native_client_sdk/src/build_tools/sdk_files.list:982: [win]tools/ncval.exe This file might be more manageable if it ...
7 years, 6 months ago (2013-06-03 18:41:52 UTC) #4
binji
7 years, 6 months ago (2013-06-03 20:55:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r203767 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698