Don't send PP_Vars/V8 values with cycles across PostMessage

webkit/plugins/ppapi/v8_var_converter.h

Index: webkit/plugins/ppapi/v8_var_converter.h
diff --git a/webkit/plugins/ppapi/v8_var_converter.h b/webkit/plugins/ppapi/v8_var_converter.h
index c19644cdf890020847d5920094ad18dd5d9b0afe..d2db0a98085487054efc02371eaf9909a1153b17 100644
--- a/webkit/plugins/ppapi/v8_var_converter.h
+++ b/webkit/plugins/ppapi/v8_var_converter.h
@@ -18,7 +18,7 @@ namespace ppapi {
 // Class to convert between PP_Vars and V8 values.
 class WEBKIT_PLUGINS_EXPORT V8VarConverter {
  public:
-  V8VarConverter();
+  V8VarConverter(bool allow_cycles);

[dmichael (off chromium), 2013/06/04 16:59:10]

Better to just always disallow them, I think. We can dig the cycle passing stuff
out of source control; no need to maintain a dead branch of code.

[raymes, 2013/06/04 19:36:06]

Done.

 
   // Converts the given PP_Var to a v8::Value. True is returned upon success.
   bool ToV8Value(const PP_Var& var,
@@ -32,6 +32,9 @@ class WEBKIT_PLUGINS_EXPORT V8VarConverter {
                    v8::Handle<v8::Context> context,
                    PP_Var* result) const;
 
+ private:
+  bool allow_cycles_;
+
   DISALLOW_COPY_AND_ASSIGN(V8VarConverter);
 };