Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: ppapi/api/ppb_messaging.idl

Issue 16140011: Don't send PP_Vars/V8 values with cycles across PostMessage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/api/ppp_messaging.idl » ('j') | ppapi/proxy/raw_var_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/api/ppb_messaging.idl
diff --git a/ppapi/api/ppb_messaging.idl b/ppapi/api/ppb_messaging.idl
index 647f7f69e643ea656a8a94f5e05d652af8ccab2a..ce4881ab1e1a887b88c9be19f7632d89ac626c8a 100644
--- a/ppapi/api/ppb_messaging.idl
+++ b/ppapi/api/ppb_messaging.idl
@@ -36,8 +36,9 @@ interface PPB_Messaging {
* JavaScript.
*
* When passing array or dictionary <code>PP_Var</code>s, the entire reference
- * graph will be converted and transferred, including reference cycles if they
- * exist.
+ * graph will be converted and transferred. If the reference graph has cycles,
+ * an undefined var will be sent instead and an error will be logged to the
dmichael (off chromium) 2013/06/04 16:59:10 Is this the behavior that was discussed in the mee
raymes 2013/06/04 19:36:06 We discussed both and there wasn't a clear decisio
dmichael (off chromium) 2013/06/05 17:05:47 Yeah, I could see both sides. Dropping it seems le
+ * console.
*
* Listeners for message events in JavaScript code will receive an object
* conforming to the HTML 5 <code>MessageEvent</code> interface.
« no previous file with comments | « no previous file | ppapi/api/ppp_messaging.idl » ('j') | ppapi/proxy/raw_var_data.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698