Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2416)

Unified Diff: ppapi/proxy/serialized_var.h

Issue 16140011: Don't send PP_Vars/V8 values with cycles across PostMessage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/serialized_var.h
diff --git a/ppapi/proxy/serialized_var.h b/ppapi/proxy/serialized_var.h
index 98cafa0dac3afe009b54e821ec53dbaa063fa768..ab7fd3e88a5b7e846bc498d3da287e2cfc8f9e3b 100644
--- a/ppapi/proxy/serialized_var.h
+++ b/ppapi/proxy/serialized_var.h
@@ -84,6 +84,10 @@ class PPAPI_PROXY_EXPORT SerializedVar {
return inner_->ReadFromMessage(m, iter);
}
+ bool is_valid_var() const {
+ return inner_->is_valid_var();
+ }
+
RawVarDataGraph* raw_var_data() const {
return inner_->raw_var_data();
}
@@ -110,6 +114,10 @@ class PPAPI_PROXY_EXPORT SerializedVar {
serialization_rules_ = serialization_rules;
}
+ bool is_valid_var() const {
+ return is_valid_var_;
+ }
+
RawVarDataGraph* raw_var_data() {
return raw_var_data_.get();
}
@@ -162,6 +170,9 @@ class PPAPI_PROXY_EXPORT SerializedVar {
CleanupMode cleanup_mode_;
+ // If the var is not properly serialized, this will be false.
+ bool is_valid_var_;
+
#ifndef NDEBUG
// When being sent or received over IPC, we should only be serialized or
// deserialized once. These flags help us assert this is true.
@@ -342,6 +353,7 @@ class PPAPI_PROXY_EXPORT SerializedVarReceiveInput {
PP_Var Get(Dispatcher* dispatcher);
PP_Var GetForInstance(Dispatcher* dispatcher, PP_Instance instance);
+ bool is_valid_var() { return serialized_.is_valid_var(); }
private:
const SerializedVar& serialized_;

Powered by Google App Engine
This is Rietveld 408576698