Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: ppapi/c/ppp_messaging.h

Issue 16140011: Don't send PP_Vars/V8 values with cycles across PostMessage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/c/ppp_messaging.h
diff --git a/ppapi/c/ppp_messaging.h b/ppapi/c/ppp_messaging.h
index b2e1f3cea22ec60b9d8bd5cc85e5d06de47811b1..697d8bcf00710eb40aeaf82b5861d969ae9f4b1d 100644
--- a/ppapi/c/ppp_messaging.h
+++ b/ppapi/c/ppp_messaging.h
@@ -3,7 +3,7 @@
* found in the LICENSE file.
*/
-/* From ppp_messaging.idl modified Tue May 21 09:01:17 2013. */
+/* From ppp_messaging.idl modified Tue Jun 4 10:47:48 2013. */
#ifndef PPAPI_C_PPP_MESSAGING_H_
#define PPAPI_C_PPP_MESSAGING_H_
@@ -52,10 +52,9 @@ struct PPP_Messaging_1_0 {
*
* When converting JavaScript arrays, any object properties whose name
* is not an array index are ignored. When passing arrays and objects, the
- * entire reference graph will be converted and transferred, including
- * reference cycles if they exist. Since <code>PP_Var</code>s are ref-counted,
- * the author of the plugin must take care if they expect to receive vars with
- * cycles. Cycles must be manually broken to correctly release the vars.
+ * entire reference graph will be converted and transferred. If the reference
+ * graph has cycles, the var will be dropped and an error will be logged to
+ * the console.
*
* The following JavaScript code invokes <code>HandleMessage</code>, passing
* the module instance on which it was invoked, with <code>message</code>

Powered by Google App Engine
This is Rietveld 408576698