Don't send PP_Vars/V8 values with cycles across PostMessage

ppapi/proxy/raw_var_data.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_PROXY_RAW_VAR_DATA_H_
 #define PPAPI_PROXY_RAW_VAR_DATA_H_
 
 #include <vector>
 
 #include "base/callback.h"
@@ skipping 33 matching lines @@
 //        | var data |
 //        |   ....   |
 //
 // Vars that reference other vars (such as Arrays or Dictionaries) use indices
 // into the message to denote which PP_Var is pointed to.
 class PPAPI_PROXY_EXPORT RawVarDataGraph {
  public:
   // Construct a RawVarDataGraph from a given root PP_Var. A null pointer
   // is returned upon failure.
   static scoped_ptr<RawVarDataGraph> Create(const PP_Var& var,
-                                            PP_Instance instance);
+                                            PP_Instance instance,
+                                            bool allow_cycles);

[dmichael (off chromium), 2013/06/04 16:59:10]

Why have this parameter? Why not just disallow cycles entirely? Do we ever pass
true?

[raymes, 2013/06/04 19:36:06]

Done.

 
   // Constructs an empty RawVarDataGraph.
   RawVarDataGraph();
   ~RawVarDataGraph();
 
   // Construct a new PP_Var from the graph. All of the PP_Vars referenced by
   // the returned PP_Var are also constructed. Each PP_Var created has a
   // ref-count equal to the number of references it has in the graph of vars.
   // The returned var (the "root") has one additional reference.
   PP_Var CreatePPVar(PP_Instance instance);
@@ skipping 189 matching lines @@
                     PickleIterator* iter) OVERRIDE;
 
  private:
   std::vector<std::pair<std::string, size_t> > children_;
 };
 
 }  // namespace proxy
 }  // namespace ppapi
 
 #endif  // PPAPI_PROXY_RAW_VAR_DATA_H_