Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 16140002: Added cpplint.py output format for eclipse (Closed)

Created:
7 years, 7 months ago by mcasas
Modified:
7 years, 4 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Added cpplint.py output format for eclipse BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M cpplint.py View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mcasas
To integrate in Eclipse, best is if the output of cpplint.py looks something like: [file:line: ...
7 years, 6 months ago (2013-05-28 09:35:40 UTC) #1
iannucci
owner lgtm
7 years, 6 months ago (2013-05-28 18:35:16 UTC) #2
iannucci
On 2013/05/28 18:35:16, iannucci wrote: > owner lgtm *owner for depot_tools, that is... I'm not ...
7 years, 6 months ago (2013-05-28 18:35:57 UTC) #3
Elliot Glaysher
On 2013/05/28 18:35:57, iannucci wrote: > On 2013/05/28 18:35:16, iannucci wrote: > > owner lgtm ...
7 years, 6 months ago (2013-05-28 21:33:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/16140002/1
7 years, 4 months ago (2013-08-22 09:42:09 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-22 09:42:18 UTC) #6
Failed to apply patch for depot_tools/cpplint.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file depot_tools/cpplint.py
  Hunk #1 succeeded at 878 with fuzz 2 (offset 62 lines).
  Hunk #2 FAILED at 3317.
  1 out of 2 hunks FAILED -- saving rejects to file depot_tools/cpplint.py.rej

Patch:       depot_tools/cpplint.py
Index: cpplint.py
diff --git depot_tools/cpplint.py depot_tools/cpplint.py
index
f95be89135adebd5206db85843ce9f5ac7ba49a9..ec7cbc4ad008308b6e056741c7ab34aecb9293d8
100755
--- a/depot_tools/cpplint.py
+++ b/depot_tools/cpplint.py
@@ -816,6 +816,9 @@ def Error(filename, linenum, category, confidence, message):
     if _cpplint_state.output_format == 'vs7':
       sys.stderr.write('%s(%s):  %s  [%s] [%d]\n' % (
           filename, linenum, message, category, confidence))
+    elif _cpplint_state.output_format == 'eclipse':
+      sys.stderr.write('%s:%s: warning: %s  [%s] [%d]\n' % (
+          filename, linenum, message, category, confidence))
     else:
       sys.stderr.write('%s:%s:  %s  [%s] [%d]\n' % (
           filename, linenum, message, category, confidence))
@@ -3314,8 +3317,8 @@ def ParseArguments(args):
     if opt == '--help':
       PrintUsage(None)
     elif opt == '--output':
-      if not val in ('emacs', 'vs7'):
-        PrintUsage('The only allowed output formats are emacs and vs7.')
+      if not val in ('emacs', 'vs7', 'eclipse'):
+        PrintUsage('The only allowed output formats are emacs, vs7 and
eclipse.')
       output_format = val
     elif opt == '--verbose':
       verbosity = int(val)

Powered by Google App Engine
This is Rietveld 408576698