chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java - Issue 1613933002: Fix crash when icons for popular sites are loaded before the suggestions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 1613933002: Fix crash when icons for popular sites are loaded before the suggestions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

index 05cab6e22965cf8cd3d11ca3e0426e4a4a22e6df..020ab42a86e2e3b80416f4b847aff7be45629f0f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

@@ -981,6 +981,7 @@ public class NewTabPageView extends FrameLayout

}

public void onIconUpdated(final String url) {

+ if (mMostVisitedItems == null) return;

// Find a matching most visited item.

for (MostVisitedItem item : mMostVisitedItems) {

if (item.getUrl().equals(url)) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »