Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1613903003: Integrate SymbolsIterator into RunSegmenter (Closed)

Created:
4 years, 11 months ago by drott
Modified:
4 years, 10 months ago
Reviewers:
kojii, eae, behdad
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, vmpstr+blinkwatch_chromium.org, dshwang, jbroman, Justin Novosad, blink-reviews-platform-graphics_chromium.org, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Integrate SymbolsIterator into RunSegmenter RunSegmenter is our API for segmenting TextRuns into sub-runs that HarfBuzz can shape. By adding the SymbolsIterator to this segmentation we gain control over emoji presentation type: text oder emoji. And we can pre-select fonts that work better for symbols, math, punctuation. BUG=580074 R=eae,kojii,behdad Committed: https://crrev.com/8d0aeb2dced892bda385668da1fae29236e858b5 Cr-Commit-Position: refs/heads/master@{#372722}

Patch Set 1 #

Patch Set 2 : Rebaseline likely due to different run segmentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -32 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.h View 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp View 4 chunks +27 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp View 5 chunks +47 lines, -29 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
drott
Depends on https://codereview.chromium.org/1613153002/# and it's probably better to finalize the review after that one lands, ...
4 years, 11 months ago (2016-01-21 15:27:10 UTC) #1
eae
What are the run-time performance implications of adding yet another iterator?
4 years, 11 months ago (2016-01-22 00:39:27 UTC) #2
behdad
lgtm
4 years, 11 months ago (2016-01-22 13:22:17 UTC) #3
drott
On 2016/01/22 00:39:27, eae wrote: > What are the run-time performance implications of adding yet ...
4 years, 11 months ago (2016-01-22 14:02:06 UTC) #4
eae
LGTM
4 years, 10 months ago (2016-02-01 06:58:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613903003/1
4 years, 10 months ago (2016-02-01 08:45:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/174182)
4 years, 10 months ago (2016-02-01 10:39:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613903003/1
4 years, 10 months ago (2016-02-01 11:07:37 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/174226)
4 years, 10 months ago (2016-02-01 13:04:43 UTC) #13
drott
Rebaseline likely due to different run segmentation
4 years, 10 months ago (2016-02-01 18:27:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613903003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613903003/20001
4 years, 10 months ago (2016-02-01 18:31:11 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-01 19:41:10 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 19:42:20 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d0aeb2dced892bda385668da1fae29236e858b5
Cr-Commit-Position: refs/heads/master@{#372722}

Powered by Google App Engine
This is Rietveld 408576698