Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1613883002: Linux Sandbox: whitelist arm64 syscalls (Closed)

Created:
4 years, 11 months ago by Riku Voipio
Modified:
4 years, 9 months ago
CC:
chromium-reviews, jln+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux Sandbox: whitelist arm64 syscalls On debian/arm64, two syscalls needed whitelisting for chromium to work with seccomp: epoll_pwait, replacing epoll_wait which is a legacy syscall not available on arm64. epoll_wait implmentation in glibc calls epoll_pwait behind scenes, so this needs to be enabled. getrlimit, missing #ifdef for arm64 in several policy definitions. test for arm64 added for each case. BUG=581018 R=keescook@chromium.org,jln@chromium.org,rsesek@chromium.org TEST=Start chrome on arm64 with seccomp enabled kernel Committed: https://crrev.com/4e8083b4ab953ba298aedfc4e79d464be15e4012 Cr-Commit-Position: refs/heads/master@{#378440}

Patch Set 1 #

Total comments: 5

Patch Set 2 : whitelist getrilimit in inherited policies #

Patch Set 3 : rebase to apply on head #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc View 1 1 chunk +2 lines, -1 line 1 comment Download
M content/common/sandbox_linux/bpf_renderer_policy_linux.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_utility_policy_linux.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/runner/host/linux_sandbox.cc View 1 2 1 chunk +4 lines, -1 line 2 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 52 (20 generated)
Riku Voipio
4 years, 11 months ago (2016-01-21 12:29:35 UTC) #1
Kees Cook
lgtm
4 years, 11 months ago (2016-01-21 19:23:57 UTC) #2
Robert Sesek
I'm curious as to why getrlimit is required. Would it be possible to get a ...
4 years, 11 months ago (2016-01-22 17:14:54 UTC) #3
Riku Voipio
On 2016/01/22 17:14:54, Robert Sesek wrote: > I'm curious as to why getrlimit is required. ...
4 years, 11 months ago (2016-01-25 13:35:19 UTC) #4
Riku Voipio
On 2016/01/25 13:35:19, Riku Voipio wrote: > On 2016/01/22 17:14:54, Robert Sesek wrote: > > ...
4 years, 10 months ago (2016-01-26 06:20:59 UTC) #6
jln (very slow on Chromium)
https://codereview.chromium.org/1613883002/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc File sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc (right): https://codereview.chromium.org/1613883002/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc#newcode417 sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc:417: case __NR_epoll_pwait: Why does ARM64 influence this? https://codereview.chromium.org/1613883002/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc#newcode610 sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc:610: ...
4 years, 10 months ago (2016-01-27 00:19:17 UTC) #8
Riku Voipio
https://codereview.chromium.org/1613883002/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc File sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc (right): https://codereview.chromium.org/1613883002/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc#newcode417 sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc:417: case __NR_epoll_pwait: On 2016/01/27 00:19:17, jln (very slow on ...
4 years, 10 months ago (2016-01-27 15:37:27 UTC) #9
Robert Sesek
https://codereview.chromium.org/1613883002/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc File sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc (right): https://codereview.chromium.org/1613883002/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc#newcode610 sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc:610: case __NR_getrlimit: On 2016/01/27 15:37:27, Riku Voipio wrote: > ...
4 years, 10 months ago (2016-01-27 16:52:31 UTC) #10
Riku Voipio
After looking around I found out that my crash is because getrlimit is allowed in ...
4 years, 10 months ago (2016-02-03 13:51:17 UTC) #12
Riku Voipio
Thanks for all reviews so far. This is the last patch needed close bug #581018 ...
4 years, 10 months ago (2016-02-09 18:33:44 UTC) #14
mdempsky
lgtm
4 years, 10 months ago (2016-02-09 19:30:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613883002/20001
4 years, 10 months ago (2016-02-09 19:34:06 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/19503) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-09 19:41:00 UTC) #20
Riku Voipio
On 2016/02/09 19:41:00, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 10 months ago (2016-02-10 13:42:20 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613883002/40001
4 years, 10 months ago (2016-02-10 22:00:47 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/144912)
4 years, 10 months ago (2016-02-10 22:17:38 UTC) #26
sky
+erg for change to mojo/shell/runner/host/linux_sandbox.cc
4 years, 10 months ago (2016-02-11 16:49:01 UTC) #29
Elliot Glaysher
https://codereview.chromium.org/1613883002/diff/40001/mojo/shell/runner/host/linux_sandbox.cc File mojo/shell/runner/host/linux_sandbox.cc (right): https://codereview.chromium.org/1613883002/diff/40001/mojo/shell/runner/host/linux_sandbox.cc#newcode80 mojo/shell/runner/host/linux_sandbox.cc:80: #if !defined(__aarch64__) So I'm not an expert on this, ...
4 years, 10 months ago (2016-02-11 18:39:05 UTC) #30
mdempsky
https://codereview.chromium.org/1613883002/diff/40001/mojo/shell/runner/host/linux_sandbox.cc File mojo/shell/runner/host/linux_sandbox.cc (right): https://codereview.chromium.org/1613883002/diff/40001/mojo/shell/runner/host/linux_sandbox.cc#newcode80 mojo/shell/runner/host/linux_sandbox.cc:80: #if !defined(__aarch64__) On 2016/02/11 18:39:05, Elliot Glaysher wrote: > ...
4 years, 10 months ago (2016-02-11 18:48:13 UTC) #31
Elliot Glaysher
On 2016/02/11 18:48:13, mdempsky wrote: > https://codereview.chromium.org/1613883002/diff/40001/mojo/shell/runner/host/linux_sandbox.cc > File mojo/shell/runner/host/linux_sandbox.cc (right): > > https://codereview.chromium.org/1613883002/diff/40001/mojo/shell/runner/host/linux_sandbox.cc#newcode80 > ...
4 years, 10 months ago (2016-02-11 18:53:43 UTC) #32
Riku Voipio
On 2016/02/11 18:53:43, Elliot Glaysher wrote: > I see. dir lgtm then. It looks like ...
4 years, 10 months ago (2016-02-16 13:52:13 UTC) #33
rickyz (no longer on Chrome)
lgtm, thanks!
4 years, 10 months ago (2016-02-16 20:41:54 UTC) #34
jln (very slow on Chromium)
Owner lgtm based on previous reviews.
4 years, 9 months ago (2016-02-26 19:45:42 UTC) #36
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613883002/40001
4 years, 9 months ago (2016-02-26 19:53:01 UTC) #38
Mark Seaborn
https://codereview.chromium.org/1613883002/diff/40001/components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc File components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc (right): https://codereview.chromium.org/1613883002/diff/40001/components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc#newcode110 components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc:110: defined(__aarch64__) This implies that we support running this NaCl ...
4 years, 9 months ago (2016-02-26 20:25:30 UTC) #39
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/29977)
4 years, 9 months ago (2016-02-26 20:46:58 UTC) #41
Riku Voipio
On 2016/02/26 20:25:30, Mark Seaborn wrote: > https://codereview.chromium.org/1613883002/diff/40001/components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc > File components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc (right): > > https://codereview.chromium.org/1613883002/diff/40001/components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc#newcode110 ...
4 years, 9 months ago (2016-02-29 10:19:13 UTC) #42
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613883002/40001
4 years, 9 months ago (2016-02-29 19:08:35 UTC) #44
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/181424)
4 years, 9 months ago (2016-02-29 19:17:36 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613883002/40001
4 years, 9 months ago (2016-03-01 15:51:56 UTC) #48
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-01 16:02:54 UTC) #50
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 16:04:21 UTC) #52
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4e8083b4ab953ba298aedfc4e79d464be15e4012
Cr-Commit-Position: refs/heads/master@{#378440}

Powered by Google App Engine
This is Rietveld 408576698