Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1613783003: Revert of Remove unused arguments of blink::PopupMenu::show(). (Closed)

Created:
4 years, 11 months ago by tkent
Modified:
4 years, 11 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove unused arguments of blink::PopupMenu::show(). (patchset #1 id:1 of https://codereview.chromium.org/1610553003/ ) Reason for revert: to revert a depending CL Original issue's description: > Remove unused arguments of blink::PopupMenu::show(). > > This CL has no behavior changes. > > Committed: https://crrev.com/fe9b3fb0d905a64db165cabe933d6dc2fe872dc4 > Cr-Commit-Position: refs/heads/master@{#370634} TBR=keishi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9b997be2440c53051db93c3a75b40b2f4b80e491 Cr-Commit-Position: refs/heads/master@{#370655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PopupMenu.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
tkent
Created Revert of Remove unused arguments of blink::PopupMenu::show().
4 years, 11 months ago (2016-01-21 09:50:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613783003/1
4 years, 11 months ago (2016-01-21 09:50:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 09:51:55 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 09:53:17 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b997be2440c53051db93c3a75b40b2f4b80e491
Cr-Commit-Position: refs/heads/master@{#370655}

Powered by Google App Engine
This is Rietveld 408576698