Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1613763003: Enable GL_CHROMIUM_bind_uniform_location, command buffer is fixed (Closed)

Created:
4 years, 11 months ago by Kimmo Kinnunen
Modified:
4 years, 11 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org, Sami Väisänen
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enable GL_CHROMIUM_bind_uniform_location, command buffer is fixed Enable GL_CHROMIUM_bind_uniform_location, command buffer implementation is fixed now. BUG=skia:4454 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1613763003 Committed: https://skia.googlesource.com/skia/+/1dc85cda5e990f379b891bb7b0356f796045e7f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Kimmo Kinnunen
Fixed when chromium patch https://chromiumcodereview.appspot.com/1610613002/ is reviewed..
4 years, 11 months ago (2016-01-21 13:05:16 UTC) #3
bsalomon
lgtm
4 years, 11 months ago (2016-01-21 14:15:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613763003/1
4 years, 11 months ago (2016-01-25 09:32:20 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 09:44:06 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1dc85cda5e990f379b891bb7b0356f796045e7f6

Powered by Google App Engine
This is Rietveld 408576698