Issue 1613763002: tests: unify duplicate build settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1613763002: tests: unify duplicate build settings (Closed)

Created:
4 years, 11 months ago by vapier

Modified:
4 years, 11 months ago

Reviewers:
Lei Zhang

CC:
google-breakpad-dev_googlegroups.com

Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

tests: unify duplicate build settings Rather than copy & paste the same set of -I flags many times over, create a single varible to hold it. BUG=chromium:579384 TEST=`make check` passes R=thestig@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/72a02f6cbff3a84587ec83c455482f06a4a09faa

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -260 lines)			Patch
	M	Makefile.am	View		27 chunks	+33 lines, -130 lines	0 comments	Download
	M	Makefile.in	View		27 chunks	+32 lines, -130 lines	0 comments	Download

Total messages: 5 (2 generated)

vapier

4 years, 11 months ago (2016-01-25 20:12:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
72a02f6cbff3a84587ec83c455482f06a4a09faa (presubmit successful).