Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: chrome/browser/net/chrome_net_log.h

Issue 16137008: Refactor net::NetLog to provide implementation of observer pattern, not just the interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/net/chrome_net_log.cc » ('j') | chrome/browser/net/chrome_net_log.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/chrome_net_log.h
diff --git a/chrome/browser/net/chrome_net_log.h b/chrome/browser/net/chrome_net_log.h
index 9bbf15276c1fc71783627cd315519a4487b3eae9..10e45fbdd0372e84555856ba6b0b424f15ebc928 100644
--- a/chrome/browser/net/chrome_net_log.h
+++ b/chrome/browser/net/chrome_net_log.h
@@ -25,46 +25,14 @@ class ChromeNetLog : public net::NetLog {
ChromeNetLog();
virtual ~ChromeNetLog();
- // NetLog implementation:
- virtual uint32 NextID() OVERRIDE;
- virtual LogLevel GetLogLevel() const OVERRIDE;
- virtual void AddThreadSafeObserver(ThreadSafeObserver* observer,
- LogLevel log_level) OVERRIDE;
- virtual void SetObserverLogLevel(ThreadSafeObserver* observer,
- LogLevel log_level) OVERRIDE;
- virtual void RemoveThreadSafeObserver(ThreadSafeObserver* observer) OVERRIDE;
-
NetLogTempFile* net_log_temp_file() {
return net_log_temp_file_.get();
}
private:
- // NetLog implementation:
- virtual void OnAddEntry(const net::NetLog::Entry& entry) OVERRIDE;
-
- // Called whenever an observer is added or removed, or has its log level
- // changed. Must have acquired |lock_| prior to calling.
- void UpdateLogLevel();
-
- // |lock_| protects access to |observers_|.
- base::Lock lock_;
-
- // Last assigned source ID. Incremented to get the next one.
- base::subtle::Atomic32 last_id_;
-
- // The lowest allowed log level, regardless of any ChromeNetLogObservers.
- // Normally defaults to LOG_BASIC, but can be changed with command line flags.
- LogLevel base_log_level_;
-
- // The current log level.
- base::subtle::Atomic32 effective_log_level_;
-
scoped_ptr<NetLogLogger> net_log_logger_;
scoped_ptr<NetLogTempFile> net_log_temp_file_;
- // |lock_| must be acquired whenever reading or writing to this.
- ObserverList<ThreadSafeObserver, true> observers_;
-
DISALLOW_COPY_AND_ASSIGN(ChromeNetLog);
};
« no previous file with comments | « no previous file | chrome/browser/net/chrome_net_log.cc » ('j') | chrome/browser/net/chrome_net_log.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698