Refactor net::NetLog to provide implementation of observer pattern, not just the interface.

net/base/capturing_net_log.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_CAPTURING_NET_LOG_H_
 #define NET_BASE_CAPTURING_NET_LOG_H_
 
 #include <string>
 #include <vector>
 
 #include "base/atomicops.h"
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/synchronization/lock.h"
 #include "base/time.h"
 #include "net/base/net_log.h"
 
 namespace base {
 class DictionaryValue;
 }
 
 namespace net {
 
-// CapturingNetLog is an implementation of NetLog that saves messages to a
-// bounded buffer.  It is intended for testing only, and is part of the
-// net_test_support project.
+// CapturingNetLog is a NetLog which instantiates Observer that saves messages
+// to a bounded buffer.  It is intended for testing only, and is part of the
+// net_test_support project. This is provided for convinience and compatilbility
+// with the old unittests.
 class CapturingNetLog : public NetLog {
  public:
   struct CapturedEntry {
     CapturedEntry(EventType type,
                   const base::TimeTicks& time,
                   Source source,
                   EventPhase phase,
                   scoped_ptr<base::DictionaryValue> params);
     // Copy constructor needed to store in a std::vector because of the
     // scoped_ptr.
@@ skipping 25 matching lines @@
     EventPhase phase;
     scoped_ptr<base::DictionaryValue> params;
   };
 
   // Ordered set of entries that were logged.
   typedef std::vector<CapturedEntry> CapturedEntryList;
 
   CapturingNetLog();
   virtual ~CapturingNetLog();
 
-  // Returns the list of all entries in the log.
+  void SetLogLevel(LogLevel log_level);
+
+  // Below methods are forwarded to capturing_net_log_observer_.
   void GetEntries(CapturedEntryList* entry_list) const;
-
-  // Fills |entry_list| with all entries in the log from the specified Source.
-  void GetEntriesForSource(NetLog::Source source,
-                           CapturedEntryList* entry_list) const;
-
-  // Returns number of entries in the log.
+  void GetEntriesForSource(Source source, CapturedEntryList* entry_list) const;
   size_t GetSize() const;
-
   void Clear();
 
-  void SetLogLevel(NetLog::LogLevel log_level);
+ private:
+  // Observer is an implementation of NetLog::ThreadSafeObserver
+  // that saves messages to a bounded buffer. It is intended for testing only,
+  // and is part of the net_test_support project.
+  class Observer : public NetLog::ThreadSafeObserver {
+   public:
+    Observer();
+    virtual ~Observer();
 
-  // NetLog implementation:
-  virtual void OnAddEntry(const net::NetLog::Entry& entry) OVERRIDE;
-  virtual uint32 NextID() OVERRIDE;
-  virtual LogLevel GetLogLevel() const OVERRIDE;
-  virtual void AddThreadSafeObserver(ThreadSafeObserver* observer,
-                                     LogLevel log_level) OVERRIDE;
-  virtual void SetObserverLogLevel(ThreadSafeObserver* observer,
-                                   LogLevel log_level) OVERRIDE;
-  virtual void RemoveThreadSafeObserver(ThreadSafeObserver* observer) OVERRIDE;
+    // Returns the list of all entries in the log.
+    void GetEntries(CapturedEntryList* entry_list) const;
 
- private:
-  // Needs to be "mutable" so can use it in GetEntries().
-  mutable base::Lock lock_;
+    // Fills |entry_list| with all entries in the log from the specified Source.
+    void GetEntriesForSource(Source source,
+                             CapturedEntryList* entry_list) const;
 
-  // Last assigned source ID.  Incremented to get the next one.
-  base::subtle::Atomic32 last_id_;
+    // Returns number of entries in the log.
+    size_t GetSize() const;
 
-  CapturedEntryList captured_entries_;
+    void Clear();
 
-  NetLog::LogLevel log_level_;
+   private:
+    // ThreadSafeObserver implementation:
+    virtual void OnAddEntry(const Entry& entry) OVERRIDE;
+
+    // Needs to be "mutable" so can use it in GetEntries().
+    mutable base::Lock lock_;
+
+    CapturedEntryList captured_entries_;
+
+    DISALLOW_COPY_AND_ASSIGN(Observer);
+  };
+
+  Observer capturing_net_log_observer_;
 
   DISALLOW_COPY_AND_ASSIGN(CapturingNetLog);
 };
 
 // Helper class that exposes a similar API as BoundNetLog, but uses a
 // CapturingNetLog rather than the more generic NetLog.
 //
 // CapturingBoundNetLog can easily be converted to a BoundNetLog using the
 // bound() method.
 class CapturingBoundNetLog {
@@ skipping 23 matching lines @@
  private:
   CapturingNetLog capturing_net_log_;
   const BoundNetLog net_log_;
 
   DISALLOW_COPY_AND_ASSIGN(CapturingBoundNetLog);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_CAPTURING_NET_LOG_H_