Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1613603002: Revert of untrusted.gypi: Remove support for old gcc newlib toolchain (Closed)

Created:
4 years, 11 months ago by Mark Seaborn
Modified:
4 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Revert of untrusted.gypi: Remove support for old gcc newlib toolchain (patchset #2 id:20001 of https://codereview.chromium.org/1581193006/ ) Reason for revert: This seems to have caused a build failure on Windows when rolled into Chromium (see https://codereview.chromium.org/1601743010/). Original issue's description: > untrusted.gypi: Remove support for old gcc newlib toolchain > > build_nexe.py can also be simplified but I'll leave that > for a subsequent CL. > > BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4352 > > Committed: https://chromium.googlesource.com/native_client/src/native_client/+/6c30fab49ef4e53b2f59353d59c3f9a7c5b21875 TBR=mcgrathr@chromium.org,sbc@chromium.org NOTREECHECKS=true # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4352 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/d6d5f6f2ca4cf89084547b0aaf1829980b37b43f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M build/untrusted.gypi View 11 chunks +24 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Mark Seaborn
Created Revert of untrusted.gypi: Remove support for old gcc newlib toolchain
4 years, 11 months ago (2016-01-21 03:05:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613603002/1
4 years, 11 months ago (2016-01-21 03:06:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613603002/1
4 years, 11 months ago (2016-01-21 07:17:42 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 07:18:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/d6d5f6f2c...

Powered by Google App Engine
This is Rietveld 408576698