Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 16136011: Generator object "next" method takes optional send value (Closed)

Created:
7 years, 6 months ago by wingo
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Generator object "next" method takes optional send value Update the generators implementation to make "next" also do the job of what was previously called "send" by taking an optional argument. Remove send, and do a bunch of renamings. R=rossberg@chromium.org BUG=v8:2355, v8:2715 Committed: http://code.google.com/p/v8/source/detail?r=15028

Patch Set 1 #

Patch Set 2 : remove mips changes #

Patch Set 3 : rebased onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -55 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/generator.js View 2 chunks +4 lines, -15 lines 0 comments Download
M src/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M test/mjsunit/harmony/generators-iteration.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/generators-objects.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/generators-runtime.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
wingo
7 years, 6 months ago (2013-06-10 08:25:24 UTC) #1
rossberg
LGTM One comment, though: you should not generally touch any MIPS code, because that is ...
7 years, 6 months ago (2013-06-10 09:17:15 UTC) #2
wingo
On 2013/06/10 09:17:15, rossberg wrote: > LGTM > > One comment, though: you should not ...
7 years, 6 months ago (2013-06-10 09:20:23 UTC) #3
wingo
7 years, 6 months ago (2013-06-10 09:26:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r15028 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698