Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: ppapi/c/ppb_var_dictionary.h

Issue 16136009: Move PPB_VarArray and PPB_VarDictionary out of dev. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/c/ppb_var_dictionary.h
diff --git a/ppapi/c/dev/ppb_var_dictionary_dev.h b/ppapi/c/ppb_var_dictionary.h
similarity index 74%
rename from ppapi/c/dev/ppb_var_dictionary_dev.h
rename to ppapi/c/ppb_var_dictionary.h
index d601071a28522024d09fbda2f77cabd2b3313e6c..01244775304048a4276f2825f842029dbf3cfe03 100644
--- a/ppapi/c/dev/ppb_var_dictionary_dev.h
+++ b/ppapi/c/ppb_var_dictionary.h
@@ -3,22 +3,22 @@
* found in the LICENSE file.
*/
-/* From dev/ppb_var_dictionary_dev.idl modified Wed Mar 13 21:47:05 2013. */
+/* From ppb_var_dictionary.idl modified Sat Jun 8 23:03:54 2013. */
-#ifndef PPAPI_C_DEV_PPB_VAR_DICTIONARY_DEV_H_
-#define PPAPI_C_DEV_PPB_VAR_DICTIONARY_DEV_H_
+#ifndef PPAPI_C_PPB_VAR_DICTIONARY_H_
+#define PPAPI_C_PPB_VAR_DICTIONARY_H_
#include "ppapi/c/pp_bool.h"
#include "ppapi/c/pp_macros.h"
#include "ppapi/c/pp_stdint.h"
#include "ppapi/c/pp_var.h"
-#define PPB_VAR_DICTIONARY_DEV_INTERFACE_0_1 "PPB_VarDictionary(Dev);0.1"
-#define PPB_VAR_DICTIONARY_DEV_INTERFACE PPB_VAR_DICTIONARY_DEV_INTERFACE_0_1
+#define PPB_VAR_DICTIONARY_INTERFACE_1_0 "PPB_VarDictionary;1.0"
+#define PPB_VAR_DICTIONARY_INTERFACE PPB_VAR_DICTIONARY_INTERFACE_1_0
/**
* @file
- * This file defines the <code>PPB_VarDictionary_Dev</code> struct providing
+ * This file defines the <code>PPB_VarDictionary</code> struct providing
* a way to interact with dictionary vars.
*/
@@ -32,7 +32,7 @@
* strings while the values can be arbitrary vars. Key comparison is always
* done by value instead of by reference.
*/
-struct PPB_VarDictionary_Dev_0_1 {
+struct PPB_VarDictionary_1_0 {
/**
* Creates a dictionary var, i.e., a <code>PP_Var</code> with type set to
* <code>PP_VARTYPE_DICTIONARY</code>.
@@ -48,26 +48,27 @@ struct PPB_VarDictionary_Dev_0_1 {
* @param[in] key A string var.
*
* @return The value that is associated with <code>key</code>. The reference
- * count is incremented on behalf of the caller. If <code>key</code> is not a
- * string var, or it doesn't exist in <code>dict</code>, an undefined var is
- * returned.
+ * count of the element returned is incremented on behalf of the caller. If
+ * <code>key</code> is not a string var, or it doesn't exist in
+ * <code>dict</code>, an undefined var is returned.
*/
struct PP_Var (*Get)(struct PP_Var dict, struct PP_Var key);
/**
- * Sets the value associated with the specified key. The dictionary is
- * responsible for holding references to its children to keep them alive.
+ * Sets the value associated with the specified key.
*
* @param[in] dict A dictionary var.
* @param[in] key A string var. If this key hasn't existed in
* <code>dict</code>, it is added and associated with <code>value</code>;
* otherwise, the previous value is replaced with <code>value</code>.
- * @param[in] value The value to set.
+ * @param[in] value The value to set. The dictionary holds a reference to it
+ * on success.
*
* @return A <code>PP_Bool</code> indicating whether the operation succeeds.
*/
PP_Bool (*Set)(struct PP_Var dict, struct PP_Var key, struct PP_Var value);
/**
- * Deletes the specified key and its associated value, if the key exists.
+ * Deletes the specified key and its associated value, if the key exists. The
+ * reference to the element will be released.
*
* @param[in] dict A dictionary var.
* @param[in] key A string var.
@@ -97,10 +98,10 @@ struct PPB_VarDictionary_Dev_0_1 {
struct PP_Var (*GetKeys)(struct PP_Var dict);
};
-typedef struct PPB_VarDictionary_Dev_0_1 PPB_VarDictionary_Dev;
+typedef struct PPB_VarDictionary_1_0 PPB_VarDictionary;
/**
* @}
*/
-#endif /* PPAPI_C_DEV_PPB_VAR_DICTIONARY_DEV_H_ */
+#endif /* PPAPI_C_PPB_VAR_DICTIONARY_H_ */

Powered by Google App Engine
This is Rietveld 408576698