Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 16136005: Update remaining files to use WeakPtr<T>::get() instead of "operator T*" (Closed)

Created:
7 years, 6 months ago by akalin
Modified:
7 years, 6 months ago
CC:
chromium-reviews, jonathan.backer, Ian Vollick, apatrick_chromium, feature-media-reviews_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Update remaining files to use WeakPtr<T>::get() instead of "operator T*" BUG=245942 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203872

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -42 lines) Patch
M cc/resources/video_resource_updater.cc View 2 chunks +2 lines, -2 lines 3 comments Download
M device/bluetooth/bluetooth_adapter_factory.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M jingle/notifier/listener/xmpp_push_client.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M media/filters/audio_renderer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/plugin_var_serialization_rules.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M ui/compositor/layer_animator.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_animator.cc View 5 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
akalin
+darin for review will probably TBR
7 years, 6 months ago (2013-06-04 05:34:32 UTC) #1
akalin
On 2013/06/04 05:34:32, akalin wrote: > +darin for review > > will probably TBR TBRing!
7 years, 6 months ago (2013-06-04 06:41:47 UTC) #2
akalin
Committed patchset #1 manually as r203872 (presubmit successful).
7 years, 6 months ago (2013-06-04 06:42:38 UTC) #3
danakj
https://codereview.chromium.org/16136005/diff/1/cc/resources/video_resource_updater.cc File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/16136005/diff/1/cc/resources/video_resource_updater.cc#newcode368 cc/resources/video_resource_updater.cc:368: if (!updater.get()) { Have you considered adding an operator ...
7 years, 6 months ago (2013-06-04 14:01:14 UTC) #4
akalin
https://codereview.chromium.org/16136005/diff/1/cc/resources/video_resource_updater.cc File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/16136005/diff/1/cc/resources/video_resource_updater.cc#newcode368 cc/resources/video_resource_updater.cc:368: if (!updater.get()) { On 2013/06/04 14:01:14, danakj wrote: > ...
7 years, 6 months ago (2013-06-04 15:45:09 UTC) #5
danakj
https://codereview.chromium.org/16136005/diff/1/cc/resources/video_resource_updater.cc File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/16136005/diff/1/cc/resources/video_resource_updater.cc#newcode368 cc/resources/video_resource_updater.cc:368: if (!updater.get()) { On 2013/06/04 15:45:15, akalin wrote: > ...
7 years, 6 months ago (2013-06-04 17:04:51 UTC) #6
darin (slow to review)
7 years, 6 months ago (2013-06-04 17:26:56 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698