Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1613583002: cc:: Remove RenderSurfaceImpl::TargetEffectTreeIndex (Closed)

Created:
4 years, 11 months ago by jaydasika
Modified:
4 years, 11 months ago
Reviewers:
ajuma, weiliangc, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc:: Remove RenderSurfaceImpl::TargetEffectTreeIndex Need to remove it as it uses layer tree hierarchy information. It is used for computing surface draw opacity which can be computed directly from effect tree. BUG=568799 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/fbdb86ee24a7e825f301cf18da3b7bd52fd20568 Cr-Commit-Position: refs/heads/master@{#370739}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -14 lines) Patch
M cc/layers/render_surface_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/render_surface_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jaydasika
PTAL
4 years, 11 months ago (2016-01-21 02:19:39 UTC) #3
ajuma
lgtm https://codereview.chromium.org/1613583002/diff/1/cc/trees/layer_tree_host_common_unittest.cc File cc/trees/layer_tree_host_common_unittest.cc (right): https://codereview.chromium.org/1613583002/diff/1/cc/trees/layer_tree_host_common_unittest.cc#newcode1427 cc/trees/layer_tree_host_common_unittest.cc:1427: // itself, but not the opacity od surface1. ...
4 years, 11 months ago (2016-01-21 14:20:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613583002/20001
4 years, 11 months ago (2016-01-21 18:52:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 18:58:04 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 18:59:53 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fbdb86ee24a7e825f301cf18da3b7bd52fd20568
Cr-Commit-Position: refs/heads/master@{#370739}

Powered by Google App Engine
This is Rietveld 408576698