Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1613543003: Timeline: unify frame computation for threaded and single-thread scenarios (Closed)

Created:
4 years, 11 months ago by caseq
Modified:
4 years, 11 months ago
Reviewers:
alph, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: unify frame computation for threaded and single-thread scenarios This removes the quirk we used to have for single-threaded compositing mode that emerged as issue 579796, while retaining compatibility with current single-threaded implementation. BUG=579796 Committed: https://crrev.com/fc3670e9a5f9efd63710abec5949e2c162e67e63 Cr-Commit-Position: refs/heads/master@{#371019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -64 lines) Patch
M third_party/WebKit/LayoutTests/inspector/tracing/frame-model.html View 1 chunk +13 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/frame-model-expected.txt View 2 chunks +21 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFrameModel.js View 8 chunks +12 lines, -45 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
caseq
4 years, 11 months ago (2016-01-21 21:47:35 UTC) #3
alph
lgtm
4 years, 11 months ago (2016-01-22 18:22:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613543003/1
4 years, 11 months ago (2016-01-22 18:41:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 20:14:27 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 20:15:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc3670e9a5f9efd63710abec5949e2c162e67e63
Cr-Commit-Position: refs/heads/master@{#371019}

Powered by Google App Engine
This is Rietveld 408576698