third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp - Issue 1613543002: Use DOMHighResTimeStamp for notification time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

Issue 1613543002: Use DOMHighResTimeStamp for notification time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Use DOMHighResTimeStamp in IntersectionObserverEntry Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/intersection-observer/timestamp.html ('K') | « third_party/WebKit/Source/core/dom/IntersectionObserver.cpp ('k') | third_party/WebKit/Source/core/dom/IntersectionObserverEntry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp b/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

index 021063299732761cc5f6d860e1c40634a624ad44..54b4c177b4277abb98f7e6efa50204a55644e337 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

@@ -61,10 +61,8 @@ void IntersectionObserverController::deliverIntersectionObservations(Timer<Inter

void IntersectionObserverController::computeTrackedIntersectionObservations()

{

- // TODO(szager): Need to define timestamp.

- double timestamp = currentTime();

for (auto& observer : m_trackedIntersectionObservers) {

- observer->computeIntersectionObservations(timestamp);

+ observer->computeIntersectionObservations();

if (observer->hasEntries())

scheduleIntersectionObserverForDelivery(*observer);

}