Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1613523002: Remove ipc_channel_unittests from Android build. (Closed)

Created:
4 years, 11 months ago by brettw
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ipc_channel_unittests from Android build. All the tests are disabled on Android because this type of test is not supported. Doing this allws us to clean up some of the preprocessor mess in this file Committed: https://crrev.com/a59908d2fb34695e6a41938683b1b66d490bb729 Cr-Commit-Position: refs/heads/master@{#370744}

Patch Set 1 #

Patch Set 2 : Remove MAYBE_ prefix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M ipc/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M ipc/ipc.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc_channel_unittest.cc View 1 3 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
brettw
4 years, 11 months ago (2016-01-20 23:26:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613523002/1
4 years, 11 months ago (2016-01-20 23:27:28 UTC) #4
Tom Sepez
LGTM. Thanks.
4 years, 11 months ago (2016-01-20 23:34:51 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/104770)
4 years, 11 months ago (2016-01-21 00:07:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613523002/20001
4 years, 11 months ago (2016-01-21 17:55:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 19:16:58 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 19:18:15 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a59908d2fb34695e6a41938683b1b66d490bb729
Cr-Commit-Position: refs/heads/master@{#370744}

Powered by Google App Engine
This is Rietveld 408576698