chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java - Issue 1613513004: Prevent Contextual Search from breaking InfoBarContainer visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 1613513004: Prevent Contextual Search from breaking InfoBarContainer visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Final comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

index ef2f8e6f2d7c3bc64c7d0229c7754691bc833208..cb7b577d8f712e87bb558da0a79c2155cab3710d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

@@ -354,8 +354,7 @@ public class ContextualSearchManager extends ContextualSearchObservable

mWereInfoBarsHidden = false;

InfoBarContainer container = getInfoBarContainer();

if (container != null) {

- container.setVisibility(View.VISIBLE);

- container.setDoStayInvisible(false);

+ container.setIsObscuredByOtherView(false);

}

@@ -435,8 +434,7 @@ public class ContextualSearchManager extends ContextualSearchObservable

InfoBarContainer container = getInfoBarContainer();

if (container != null && container.getVisibility() == View.VISIBLE) {

mWereInfoBarsHidden = true;

- container.setVisibility(View.INVISIBLE);

- container.setDoStayInvisible(true);

+ container.setIsObscuredByOtherView(true);

}