[SafeBrowsing] Alternate extensions should also be subject to block list.

chrome/browser/safe_browsing/unverified_download_policy_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/unverified_download_policy.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/callback_helpers.h"
 #include "base/command_line.h"
@@ skipping 119 matching lines @@
 };
 
 }  // namespace
 
 // Verify that SafeBrowsing whitelists can override field trials.
 TEST_F(UnverifiedDownloadPolicyTest, Whitelist) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       switches::kDisallowUncheckedDangerousDownloads);
 
   base::FilePath test_file_path(FILE_PATH_LITERAL("foo.exe"));
+  std::vector<base::FilePath::StringType> test_extensions;
 
   CompletionCallback completion_callback;
-  CheckUnverifiedDownloadPolicy(GURL(), test_file_path,
+  CheckUnverifiedDownloadPolicy(GURL(), test_file_path, test_extensions,
                                 completion_callback.GetCallback());
   EXPECT_EQ(UnverifiedDownloadPolicy::DISALLOWED,
             completion_callback.WaitForResult());
 
   // Not http/s and hence isn't covered by the whitelist.
   CheckUnverifiedDownloadPolicy(GURL("ftp://supported.example.com/foo/bar"),
-                                test_file_path,
+                                test_file_path, test_extensions,
                                 completion_callback.GetCallback());
   EXPECT_EQ(UnverifiedDownloadPolicy::DISALLOWED,
             completion_callback.WaitForResult());
 
   CheckUnverifiedDownloadPolicy(GURL("http://supported.example.com/foo/bar"),
-                                test_file_path,
+                                test_file_path, test_extensions,
                                 completion_callback.GetCallback());
   EXPECT_EQ(UnverifiedDownloadPolicy::ALLOWED,
             completion_callback.WaitForResult());
 
   CheckUnverifiedDownloadPolicy(GURL("http://unsupported.example.com/foo/bar"),
-                                test_file_path,
+                                test_file_path, test_extensions,
                                 completion_callback.GetCallback());
   EXPECT_EQ(UnverifiedDownloadPolicy::DISALLOWED,
             completion_callback.WaitForResult());
 
   CheckUnverifiedDownloadPolicy(GURL("https://supported.example.com/foo/bar"),
-                                test_file_path,
+                                test_file_path, test_extensions,
                                 completion_callback.GetCallback());
   EXPECT_EQ(UnverifiedDownloadPolicy::ALLOWED,
             completion_callback.WaitForResult());
+}
+
+TEST_F(UnverifiedDownloadPolicyTest, AlternateExtensions) {
+  base::CommandLine::ForCurrentProcess()->AppendSwitch(
+      switches::kDisallowUncheckedDangerousDownloads);
+  CompletionCallback completion_callback;
+
+  base::FilePath test_file_path(FILE_PATH_LITERAL("foo.txt"));
+  std::vector<base::FilePath::StringType> test_extensions;
+
+  CheckUnverifiedDownloadPolicy(GURL(), test_file_path, test_extensions,
+                                completion_callback.GetCallback());
+  EXPECT_EQ(UnverifiedDownloadPolicy::ALLOWED,
+            completion_callback.WaitForResult());
+
+  test_extensions.push_back(FILE_PATH_LITERAL(".exe"));
+  CheckUnverifiedDownloadPolicy(GURL(), test_file_path, test_extensions,
+                                completion_callback.GetCallback());
+  EXPECT_EQ(UnverifiedDownloadPolicy::DISALLOWED,
+            completion_callback.WaitForResult());
+
+  test_extensions.clear();
+  test_extensions.push_back(FILE_PATH_LITERAL(".txt"));
+  test_extensions.push_back(FILE_PATH_LITERAL(".exe"));
+  CheckUnverifiedDownloadPolicy(GURL(), test_file_path, test_extensions,
+                                completion_callback.GetCallback());
+  EXPECT_EQ(UnverifiedDownloadPolicy::DISALLOWED,
+            completion_callback.WaitForResult());
+
+  test_extensions.clear();
+  test_extensions.push_back(FILE_PATH_LITERAL("e"));
+  CheckUnverifiedDownloadPolicy(GURL(), test_file_path, test_extensions,
+                                completion_callback.GetCallback());
+  EXPECT_EQ(UnverifiedDownloadPolicy::ALLOWED,
+            completion_callback.WaitForResult());
 }
 
 // Verify behavior when the SafeBrowsing service is disabled.
 TEST_F(UnverifiedDownloadPolicyTest, ServiceDisabled) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       switches::kDisallowUncheckedDangerousDownloads);
 
   testing_profile_->GetPrefs()->SetBoolean(prefs::kSafeBrowsingEnabled, false);
   base::RunLoop().RunUntilIdle();
 
   base::FilePath test_file_path(FILE_PATH_LITERAL("foo.exe"));
+  std::vector<base::FilePath::StringType> test_extensions;
 
   CompletionCallback completion_callback;
   CheckUnverifiedDownloadPolicy(GURL("http://supported.example.com/foo/bar"),
-                                test_file_path,
+                                test_file_path, test_extensions,
                                 completion_callback.GetCallback());
   EXPECT_EQ(UnverifiedDownloadPolicy::ALLOWED,
             completion_callback.WaitForResult());
 }
 
 }  // namespace safe_browsing